Windows: resolved merge conflicts and added tests #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for installing on Windows using the
install_method
ofwindows
. It uses the Chocolatey package manager.I have made the Windows tests conditional on setting the
TEST_WINDOWS
environment variable to a truthy value. I tried using vagrant boxes from [https://github.com/joefitzgerald/packer-windows] and [https://github.com/boxcutter/windows], but I was not able to make them work. The box used is approximately 3 GB to download. Provisioning only seems to work if you login at boot time; annoying, but it works.