Misc bugfixes #325
Merged
Misc bugfixes #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This quells a warning about "Option environment must be a kind of [String]" that gets emitted during rspec runs. Chef 13 will not allow the type mismatch.
The consul_service resource was using a default value attribute that was not configured anywhere. This changes it to use the same default as consul_config.
|
Not sure what's up with the build failure. Looking at the project build history it seems pretty random. |
On my system, this fixes the following failures under Centos 5:
1) Service "consul" should be enabled
Failure/Error: it { should be_enabled }
expected Service "consul" to be enabled
/bin/sh -c chkconfig\ --list\ consul\ \|\ grep\ 3:on
# /tmp/verifier/suites/serverspec/default_spec.rb:26:in `block (2 levels) in <top (required)>'
2) Service "consul" should be running
Failure/Error: it { should be_running }
expected Service "consul" to be running
/bin/sh -c service\ consul\ status
# /tmp/verifier/suites/serverspec/default_spec.rb:27:in `block (2 levels) in <top (required)>'
| @@ -64,7 +64,7 @@ _start() { | |||
| daemon \ | |||
| --pidfile=$pidfile \ | |||
| --user=$user \ | |||
| " { $exec <%= @daemon_options %> &>> $logfile & } ; echo \$! >| $pidfile " | |||
| " { $exec <%= @daemon_options %> > $logfile 2>&1 & } ; echo \$! >| $pidfile " | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugfixes: