Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update cookbook to use poise-archive for unzipping. #348

Merged
merged 1 commit into from
Oct 4, 2016
Merged

WIP: Update cookbook to use poise-archive for unzipping. #348

merged 1 commit into from
Oct 4, 2016

Conversation

johnbellone
Copy link
Contributor

No description provided.

legal90
legal90 approved these changes Oct 4, 2016
View reviewed changes
Copy link
Contributor

@legal90 legal90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But I would recommend to rebase the branch to get Travis CI builds passed.

@johnbellone johnbellone merged commit 966dadf into master Oct 4, 2016
@johnbellone johnbellone deleted the poise-archive branch October 4, 2016 13:42
@legal90 legal90 mentioned this pull request Oct 5, 2016
Merged
@legal90
Copy link
Contributor

legal90 commented Oct 5, 2016 •
edited
Loading

As I see, unpacking by poise_archive works weird. It tells that everything is OK:

      * directory[/opt/consul/0.7.0] action create (up to date)
      - unpack archive https://releases.hashicorp.com/consul/0.7.0/consul_0.7.0_linux_amd64.zip to /opt/consul/0.7.0
    * link[/usr/local/bin/consul] action create
      - create symlink at /usr/local/bin/consul to /opt/consul/0.7.0/consul

But /opt/consul/0.7.0/ is empty after that. Reproduced on the following suites defined in .kitchen.dokken.yml:

  • default-centos-6
  • default-centos-7

UPDATE: That was fiexd by #356

legal90
legal90 reviewed Oct 7, 2016
View reviewed changes
metadata.rb
depends 'poise-service', '~> 1.4'
depends 'rubyzip', '~> 1.3'

This comment was marked as outdated.

Sign in to view

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@legal90 legal90 legal90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnbellone @legal90