Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for specifying the raft protocol version #425

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

poblahblahblah
Copy link
Contributor

consul 0.8.0 includes some autopilot features look really nice. In order to enable these you need to specify the raft protocol version.

This change allows us to do that.

Copy link
Contributor

@legal90 legal90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, except setting the default value of raft_protocol explicitly.

@@ -76,6 +76,7 @@ class ConsulConfig < Chef::Resource
attribute(:performance, kind_of: [Hash, Mash])
attribute(:ports, kind_of: [Hash, Mash])
attribute(:protocol, kind_of: String)
attribute(:raft_protocol, kind_of: Integer, default: false)

This comment was marked as outdated.

@codecov-io
Copy link

codecov-io commented Apr 8, 2017

Codecov Report

Merging #425 into master will increase coverage by 12.51%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #425       +/-   ##
===========================================
+ Coverage   58.38%   70.89%   +12.51%     
===========================================
  Files           7        7               
  Lines         346      347        +1     
===========================================
+ Hits          202      246       +44     
+ Misses        144      101       -43
Impacted Files Coverage Δ
libraries/consul_config.rb 97.52% <100%> (+20.02%) ⬆️
libraries/helpers.rb 54.05% <0%> (+5.4%) ⬆️
libraries/consul_definition.rb 91.66% <0%> (+47.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9b75c...2e5d12f. Read the comment docs.

@poblahblahblah
Copy link
Contributor Author

@legal90 sounds good - PR updated to remove the default.

@legal90 legal90 merged commit 6689d41 into sous-chefs:master Apr 8, 2017
@legal90
Copy link
Contributor

legal90 commented Apr 8, 2017

@poblahblahblah Thank you!

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants