Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API updates & Add encrypt param #56

Merged
merged 1 commit into from
Oct 16, 2014
Merged

API updates & Add encrypt param #56

merged 1 commit into from
Oct 16, 2014

Conversation

benjaminws
Copy link
Contributor

Cleaned up previous PR.

API updates

  • Update serverspec API usage
  • Update how ui is extracted, the file itself changed
  • Increase coverage slightly with added test when using runit
  • Cleanup helpers with more convenience methods

Add encrypt parameter

  • Add test
  • Add value to kitchen config

- Update serverspec API usage
- Update how ui is extracted, the file itself changed
- Increase coverage slightly with added test when using runit
- Cleanup helpers with more convenience methods

Add encrypt parameter

- Add test
- Add value to kitchen config
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a23a150 on benjaminws:api-updates-and-encrypt-param into f8f2cf1 on johnbellone:master.

@reset
Copy link
Contributor

reset commented Oct 16, 2014

Thanks @benjaminws !

@reset reset closed this Oct 16, 2014
@reset reset reopened this Oct 16, 2014
reset added a commit that referenced this pull request Oct 16, 2014
@reset reset merged commit 3b298b8 into sous-chefs:master Oct 16, 2014
@@ -19,9 +19,9 @@
install_checksum = node['consul']['checksums'].fetch(install_version)

ark 'consul_ui' do
path node['consul']['ui_dir']
path node['consul']['data_dir']
home_dir node['consul']['ui_dir']

This comment was marked as outdated.

This comment was marked as outdated.

@thedebugger
Copy link
Contributor

One thing, I noticed about the pull request is "encrypt" attribute is not present in the default attribute. Why is that so? Ideally, we should use the data bags for that.

@benjaminws
Copy link
Contributor Author

@thedebugger Ahh, good eye. The default for the attribute is nil, so it is not in the default attributes. Check out https://github.com/johnbellone/consul-cookbook/blob/master/recipes/_service.rb#L113 to see how it decides when to use the attribute. Also, I didn't document usage in this pull request, but have corrected that in #57

johnbellone added a commit that referenced this pull request Oct 22, 2014
This is a version bump as commits for #56 caused some breaking
changes. Since we haven't pushed 0.4.4 yet to supermarket (or tagged
release, for that matter) let's bump this. There are a few pull-requests
that we are waiting on prior to release.
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants