Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sourcemaps for JS files that are modified by ember-scoped-css #24

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

candunaj
Copy link
Contributor

This PRs fixes source maps for components with co-located css files. In this case, only the template string is rewritten, so the code structure stays the same. This is why we can return map: null from the transform method.

Note:
Source maps for gjs and gts components with style tags are broken. It can be fixed only after the rollup for style tags will be implemented.

@candunaj candunaj marked this pull request as ready for review April 26, 2023 08:14
@candunaj candunaj requested a review from mansona April 26, 2023 08:15
@candunaj candunaj changed the title Fixed source maps Fix sourcemaps for JS files that are modified by ember-scoped-css Apr 26, 2023
@mansona mansona merged commit 8cf0afc into main Apr 26, 2023
@mansona mansona deleted the source-maps branch April 26, 2023 09:20
@mansona mansona added the bug Something isn't working label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants