You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.
should compile, but (d: Node, i: Int) => d.id is not lifted or recognised as a js.thisFunction2
I've read http://stackoverflow.com/questions/27577368/d3-js-key-function-running-twice-on-simple-selector-array-combo. The current definition might be technically spoken correct but of little use if you don't overload it as to accept the above. Instantiating from js.thisFunction2 may be useful to mimic this binding from js in scala. But to pass a closure as argument, it just makes things complex. The point made on stackoverflow is that the passed function should work both on the selected data as well on the new data.
In case of
To make the API useful
should compile, but
(d: Node, i: Int) => d.id
is not lifted or recognised as ajs.thisFunction2
I've read http://stackoverflow.com/questions/27577368/d3-js-key-function-running-twice-on-simple-selector-array-combo. The current definition might be technically spoken correct but of little use if you don't overload it as to accept the above. Instantiating from
js.thisFunction2
may be useful to mimicthis
binding from js in scala. But to pass a closure as argument, it just makes things complex. The point made on stackoverflow is that the passed function should work both on the selected data as well on the new data.In case of
The type relation should be:
N2 >: N1
andN2 >: Node
or when
N2 == Node
thenN1 <: Node
as such I would propose both, next to the thisFunction based API if you like
The text was updated successfully, but these errors were encountered: