Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in data_quality vue #3305

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix typo in data_quality vue #3305

merged 1 commit into from
Nov 19, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 19, 2024

This PR fixes a typo introduced in #3268 preventing the DQ plugin from rendering. #3268 was not backported or released, so this does not need to be backported or have a changelog entry.

preventing showing
@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Nov 19, 2024
@kecnry kecnry added this to the 4.1 milestone Nov 19, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Nov 19, 2024
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, thanks.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (896d4d9) to head (268f999).
Report is 100 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3305   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files         125      125           
  Lines       19036    19036           
=======================================
  Hits        16906    16906           
  Misses       2130     2130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry merged commit a6dffff into spacetelescope:main Nov 19, 2024
32 checks passed
@kecnry kecnry deleted the dq-typo branch November 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants