Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bokeh file_html Call #1514

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

mfixstsci
Copy link
Collaborator

Bokeh's file_html method takes multiple optional parameters. Without specifying the parameter names, the method gets confused by the positions of the parameters passed in the method call.

@mfixstsci mfixstsci requested a review from bhilbert4 March 14, 2024 13:45
@pep8speaks
Copy link

pep8speaks commented Mar 14, 2024

Hello @mfixstsci, Thank you for updating !

Line 138:16: E124 closing bracket does not match visual indentation
Line 151:64: E502 the backslash is redundant between brackets
Line 153:17: E124 closing bracket does not match visual indentation
Line 306:88: W291 trailing whitespace

Comment last updated at 2024-03-14 13:50:55 UTC

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mfixstsci mfixstsci merged commit 9bb443d into spacetelescope:develop Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants