Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show file anomalies on exposure group page #1564

Merged

Conversation

BradleySappington
Copy link
Collaborator

When viewing groups of exposures, show table of anomalies for each file.
Update how tables get populated to allow for dynamic setting of column pairs.

@pep8speaks
Copy link

pep8speaks commented May 7, 2024

Hello @BradleySappington, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2024-05-07 16:29:57 UTC

@BradleySappington
Copy link
Collaborator Author

Screenshot 2024-05-07 at 10 56 16 AM

@BradleySappington
Copy link
Collaborator Author

@bhilbert4 , I updated your table maker to designate the table id (so multiple tables per page can use it), and to take a user defined "nr_paired_columns" parameter. So we can use that for any shape table that has key/value combo moving forward

@bhilbert4
Copy link
Collaborator

Nice! Looks good. Have you tested on a NIRCam group that has 10 detectors?

@mfixstsci
Copy link
Collaborator

@BradleySappington this looks great! I am curious along with @bhilbert4 about how that would look. @bhilbert4 do you know of an example off of the top of your head that will have a large number of detectors that Brad could test on?

@bhilbert4
Copy link
Collaborator

Looks like jw01022099001_03101_00001 should have all 10 nircam detectors, when running locally.

@mfixstsci
Copy link
Collaborator

Looks like jw01022099001_03101_00001 should have all 10 nircam detectors, when running locally.

Thank you 🙏

@BradleySappington
Copy link
Collaborator Author

@mfixstsci and @bhilbert4 Here ya go!

Screenshot 2024-05-07 at 11 55 46 AM

@mfixstsci
Copy link
Collaborator

@mfixstsci and @bhilbert4 Here ya go!
Screenshot 2024-05-07 at 11 55 46 AM

oh yeah, this rocks. I approve 👍

@bhilbert4
Copy link
Collaborator

Yeah, looks good!

@BradleySappington
Copy link
Collaborator Author

awesome, thanks! I'll merge once its approved

jwql/website/apps/jwql/views.py Show resolved Hide resolved
jwql/website/apps/jwql/static/js/jwql.js Show resolved Hide resolved
@mfixstsci
Copy link
Collaborator

awesome, thanks! I'll merge once its approved

Send it when you are ready @BradleySappington

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think the NIRSPec and NIRCam teams will be happy.

jwql/website/apps/jwql/data_containers.py Show resolved Hide resolved
jwql/website/apps/jwql/views.py Show resolved Hide resolved
@BradleySappington BradleySappington merged commit f39f3c1 into spacetelescope:develop May 7, 2024
4 checks passed
@BradleySappington BradleySappington deleted the mark_anomalies branch May 7, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate an anomaly is marked in some detectors
4 participants