-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show file anomalies on exposure group page #1564
show file anomalies on exposure group page #1564
Conversation
Hello @BradleySappington, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2024-05-07 16:29:57 UTC |
@bhilbert4 , I updated your table maker to designate the table id (so multiple tables per page can use it), and to take a user defined "nr_paired_columns" parameter. So we can use that for any shape table that has key/value combo moving forward |
Nice! Looks good. Have you tested on a NIRCam group that has 10 detectors? |
@BradleySappington this looks great! I am curious along with @bhilbert4 about how that would look. @bhilbert4 do you know of an example off of the top of your head that will have a large number of detectors that Brad could test on? |
Looks like jw01022099001_03101_00001 should have all 10 nircam detectors, when running locally. |
Thank you 🙏 |
@mfixstsci and @bhilbert4 Here ya go! ![]() |
oh yeah, this rocks. I approve 👍 |
Yeah, looks good! |
awesome, thanks! I'll merge once its approved |
Send it when you are ready @BradleySappington |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I think the NIRSPec and NIRCam teams will be happy.
When viewing groups of exposures, show table of anomalies for each file.
Update how tables get populated to allow for dynamic setting of column pairs.