-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pip install
in CI
#319
Conversation
@zacharyburnett would it be possible, or make sense, to remove the line @pllim and I are talking about in #279? It would be nice to see if the tests are still passing once that is removed. Thanks! |
LGTM. Yes, Python 3.7 has reached EOL and should be removed, which you did. |
And yes, would be nice to remove oldest-supported-numpy though it is technically out of scope here. Depends on how many PRs you feel like opening today. Has to be done, but can be here or a follow-up. |
sure, I'll remove |
Ok, this looks ready to me |
Boom, still passing. Thank you @zacharyburnett |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Need to update docs to make sure we are using python >=3.9
A grep like this in root dir should smoke most of them out.
|
Then Python 3.8 would pick up an older numpy. Up to you whether you want to drop it or not here, but you do not have to. Though I think astropy also dropped it for upcoming v6. |
use
pip install .[test]
@mfixstsci