Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pip install in CI #319

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Aug 21, 2023

use pip install .[test] @mfixstsci

@mfixstsci
Copy link
Collaborator

@zacharyburnett would it be possible, or make sense, to remove the line @pllim and I are talking about in #279? It would be nice to see if the tests are still passing once that is removed. Thanks!

@pllim
Copy link

pllim commented Aug 21, 2023

LGTM. Yes, Python 3.7 has reached EOL and should be removed, which you did.

@pllim
Copy link

pllim commented Aug 21, 2023

And yes, would be nice to remove oldest-supported-numpy though it is technically out of scope here. Depends on how many PRs you feel like opening today. Has to be done, but can be here or a follow-up.

@zacharyburnett
Copy link
Contributor Author

sure, I'll remove oldest-supported-numpy (not sure why I added it in the first place, sorry), and see

@zacharyburnett
Copy link
Contributor Author

Ok, this looks ready to me

@mfixstsci
Copy link
Collaborator

Boom, still passing. Thank you @zacharyburnett

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Need to update docs to make sure we are using python >=3.9

@pllim
Copy link

pllim commented Aug 21, 2023

A grep like this in root dir should smoke most of them out.

grep -ri python . | grep "3\.7"

@mfixstsci mfixstsci merged commit f49b529 into spacetelescope:master Aug 21, 2023
3 checks passed
@zacharyburnett
Copy link
Contributor Author

Numpy also dropped supporting Python 3.8 in new versions; should the required Python version in pyproject.toml also be updated?

requires-python = ">=3.8"

There is also a reference in README.md:

This package is supported in python 3.8 and 3.9

@pllim
Copy link

pllim commented Aug 21, 2023

Numpy also dropped supporting Python 3.8 in new versions

Then Python 3.8 would pick up an older numpy. Up to you whether you want to drop it or not here, but you do not have to. Though I think astropy also dropped it for upcoming v6.

@zacharyburnett zacharyburnett deleted the fix/ci branch August 21, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants