From 4a7802f8d5252792ab9b988defe5ed06ebfe6a3c Mon Sep 17 00:00:00 2001 From: William Jamieson Date: Fri, 7 Jul 2023 09:27:32 -0400 Subject: [PATCH 1/2] Remove final bits of randomness left in maker utils and tests --- src/roman_datamodels/maker_utils/_ref_files.py | 4 ++-- tests/test_open.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/roman_datamodels/maker_utils/_ref_files.py b/src/roman_datamodels/maker_utils/_ref_files.py index df8effca..cf9e8a5a 100644 --- a/src/roman_datamodels/maker_utils/_ref_files.py +++ b/src/roman_datamodels/maker_utils/_ref_files.py @@ -322,8 +322,8 @@ def _mk_phot_table_entry(key, **kwargs): } else: entry = { - "photmjsr": kwargs.get("photmjsr", 1.0e-15 * np.random.random() * u.megajansky / u.steradian), - "uncertainty": kwargs.get("uncertainty", 1.0e-16 * np.random.random() * u.megajansky / u.steradian), + "photmjsr": kwargs.get("photmjsr", 1.0e-15 * u.megajansky / u.steradian), + "uncertainty": kwargs.get("uncertainty", 1.0e-16 * u.megajansky / u.steradian), } entry["pixelareasr"] = kwargs.get("pixelareasr", 1.0e-13 * u.steradian) diff --git a/tests/test_open.py b/tests/test_open.py index 91c5af76..e8525160 100644 --- a/tests/test_open.py +++ b/tests/test_open.py @@ -85,7 +85,7 @@ def test_path_input(tmp_path): def test_model_input(tmp_path): file_path = tmp_path / "test.asdf" - data = u.Quantity(np.random.uniform(size=(4, 4)).astype(np.float32), u.electron / u.s, dtype=np.float32) + data = u.Quantity(np.random.default_rng(42).uniform(size=(4, 4)).astype(np.float32), u.electron / u.s, dtype=np.float32) with asdf.AsdfFile() as af: af.tree = {"roman": utils.mk_level2_image(shape=(8, 8))} From 32b1395522e033660e1e6e213d0a6f4529a2d525 Mon Sep 17 00:00:00 2001 From: William Jamieson Date: Fri, 7 Jul 2023 09:31:03 -0400 Subject: [PATCH 2/2] update changes --- CHANGES.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGES.rst b/CHANGES.rst index 496e4c71..f309c1e8 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -7,10 +7,12 @@ - Make ``maker_utils`` return the node when writing the node to a file. [#218] +- Clean up overlooked randomness in ``maker_utils`` and tests. [#236] + 0.16.1 (2023-06-27) =================== -A minor release to set the minimum version of RADD to 0.16.0. +A minor release to set the minimum version of RAD to 0.16.0. 0.16.0 (2023-06-23) ===================