From da973e4ef65ca5feffd34c384054aad0b5b5bbf1 Mon Sep 17 00:00:00 2001 From: chapman39 Date: Fri, 19 Dec 2025 14:43:37 -0800 Subject: [PATCH 1/4] Axom: Update ROCm root var --- repos/spack_repo/builtin/packages/axom/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repos/spack_repo/builtin/packages/axom/package.py b/repos/spack_repo/builtin/packages/axom/package.py index 08936cec0b3..09fa1b32192 100644 --- a/repos/spack_repo/builtin/packages/axom/package.py +++ b/repos/spack_repo/builtin/packages/axom/package.py @@ -374,7 +374,7 @@ def initconfig_hardware_entries(self): hip_link_flags = "" - rocm_root = spec["llvm-amdgpu"].prefix + rocm_root = os.path.dirname(spec["llvm-amdgpu"].prefix) entries.append(cmake_cache_path("ROCM_ROOT_DIR", rocm_root)) # Recommended MPI flags From 9cf148c0bb58240b614a52d858a8a609e66eeb84 Mon Sep 17 00:00:00 2001 From: chapman39 Date: Fri, 2 Jan 2026 14:51:48 -0800 Subject: [PATCH 2/4] fix wrong version --- repos/spack_repo/builtin/packages/mfem/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repos/spack_repo/builtin/packages/mfem/package.py b/repos/spack_repo/builtin/packages/mfem/package.py index 26c74dc0ee6..f7767949eb8 100644 --- a/repos/spack_repo/builtin/packages/mfem/package.py +++ b/repos/spack_repo/builtin/packages/mfem/package.py @@ -767,7 +767,7 @@ def find_optional_library(name, prefix): hypre_rocm_libs += hypre["rocsparse"].libs if "^rocrand" in hypre: hypre_rocm_libs += hypre["rocrand"].libs - if hypre.satisfies("@2.39.0:"): + if hypre.satisfies("@2.29.0:"): if "^rocsolver" in hypre: hypre_rocm_libs += hypre["rocsolver"].libs if "^rocblas" in hypre: From 93a6199a2d3457aca38c4e2101a73c7462b7d940 Mon Sep 17 00:00:00 2001 From: Alex Tyler Chapman <100869159+chapman39@users.noreply.github.com> Date: Mon, 5 Jan 2026 15:21:30 -0800 Subject: [PATCH 3/4] Apply suggestions from code review --- repos/spack_repo/builtin/packages/mfem/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repos/spack_repo/builtin/packages/mfem/package.py b/repos/spack_repo/builtin/packages/mfem/package.py index f7767949eb8..20e25c698c3 100644 --- a/repos/spack_repo/builtin/packages/mfem/package.py +++ b/repos/spack_repo/builtin/packages/mfem/package.py @@ -767,7 +767,7 @@ def find_optional_library(name, prefix): hypre_rocm_libs += hypre["rocsparse"].libs if "^rocrand" in hypre: hypre_rocm_libs += hypre["rocrand"].libs - if hypre.satisfies("@2.29.0:"): + if hypre.satisfies("@2.26.0:"): if "^rocsolver" in hypre: hypre_rocm_libs += hypre["rocsolver"].libs if "^rocblas" in hypre: From d87b2b8d81b0d456ca16dbee15b0e93feb06f566 Mon Sep 17 00:00:00 2001 From: Alex Tyler Chapman <100869159+chapman39@users.noreply.github.com> Date: Mon, 5 Jan 2026 15:45:40 -0800 Subject: [PATCH 4/4] Apply suggestions from code review --- repos/spack_repo/builtin/packages/mfem/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repos/spack_repo/builtin/packages/mfem/package.py b/repos/spack_repo/builtin/packages/mfem/package.py index 20e25c698c3..f7767949eb8 100644 --- a/repos/spack_repo/builtin/packages/mfem/package.py +++ b/repos/spack_repo/builtin/packages/mfem/package.py @@ -767,7 +767,7 @@ def find_optional_library(name, prefix): hypre_rocm_libs += hypre["rocsparse"].libs if "^rocrand" in hypre: hypre_rocm_libs += hypre["rocrand"].libs - if hypre.satisfies("@2.26.0:"): + if hypre.satisfies("@2.29.0:"): if "^rocsolver" in hypre: hypre_rocm_libs += hypre["rocsolver"].libs if "^rocblas" in hypre: