Merge pull request #34 from spaze/spaze/optional-parentheses

Make parentheses optional in disallowed calls definition
spaze · Sep 29, 2020 · 935a645 · 935a645
2 parents fce3aa4 + 6ed9a88
commit 935a645
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/DisallowedCall.php b/src/DisallowedCall.php
@@ -33,7 +33,7 @@ class DisallowedCall
 	 */
 	public function __construct(string $call, ?string $message, array $allowIn, array $allowParamsInAllowed, array $allowParamsAnywhere)
 	{
-		$this->call = $call;
+		$this->call = (substr($call, -2) === '()' ? $call : $call . '()');
 		$this->message = $message;
 		$this->allowIn = $allowIn;
 		$this->allowParamsInAllowed = $allowParamsInAllowed;

diff --git a/tests/FunctionCallsTest.php b/tests/FunctionCallsTest.php
@@ -35,7 +35,7 @@ protected function getRule(): Rule
 					]
 				],
 				[
-					'function' => 'printf()',
+					'function' => 'printf',
 					'allowIn' => [
 						'src/disallowed-allowed/*.php',
 						'src/*-allow/*.*',

diff --git a/tests/MethodCallsTest.php b/tests/MethodCallsTest.php
@@ -37,7 +37,7 @@ protected function getRule(): Rule
 					],
 				],
 				[
-					'method' => 'Traits\TestTrait::x()',
+					'method' => 'Traits\TestTrait::x',
 					'message' => 'method TestTrait::x() is dangerous',
 					'allowIn' => [
 						'src/disallowed-allowed/*.php',

diff --git a/tests/StaticCallsTest.php b/tests/StaticCallsTest.php
@@ -34,7 +34,7 @@ protected function getRule(): Rule
 					'allowParamsInAllowed' => [],
 				],
 				[
-					'method' => 'Fiction\Pulp\Royale::withoutCheese()',
+					'method' => 'Fiction\Pulp\Royale::withoutCheese',
 					'message' => 'a Quarter Pounder without Cheese?',
 					'allowIn' => [
 						'src/disallowed-allowed/*.php',