Tracking Vector documentation #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we can also close #964 as part of landing this. |
annevk
force-pushed
the
annevk/tracking-vector-docs
branch
from
9a07970 to
cb95c65
Compare
tabatkins
requested changes
Jan 17, 2020
|
Done. You don't use squash and merge by the way? |
|
I prefer linear history when I can, and for some reason they don't offer a squash-and-rebase option |
|
That's what squash and merge does. |
|
(At the WHATWG we also really like linear history.) |
Wait, really? Then why do they call it "squash and merge"??? /me goes to look at documentation |
|
Well gosh dang it, indeed it does. It specifically enforces a fast-forward commit, which effectively rebases. Okay, I'm changing the settings then, dang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs #1587 to land first and then I'll regenerate. It would also be better if Infra's tracking vector definition was indexed so no warnings are generated.