From 1c056b3aef99f491568b4ef9b6ca41cda9d3da77 Mon Sep 17 00:00:00 2001 From: Adam Hathcock Date: Thu, 30 Jan 2025 12:48:41 +0000 Subject: [PATCH 1/2] Better handle UnobservedTaskExceptions without the Event Aggregator. Logs will have them. --- .../ContainerRegistration.cs | 25 +++++++++++++------ 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/DUI3/Speckle.Connectors.DUI/ContainerRegistration.cs b/DUI3/Speckle.Connectors.DUI/ContainerRegistration.cs index c05fe2332..e7f706452 100644 --- a/DUI3/Speckle.Connectors.DUI/ContainerRegistration.cs +++ b/DUI3/Speckle.Connectors.DUI/ContainerRegistration.cs @@ -54,14 +54,25 @@ public static IServiceCollection AddEventsAsTransient(this IServiceCollection se public static IServiceProvider UseDUI(this IServiceProvider serviceProvider, bool initializeDocumentStore = true) { //observe the unobserved! - TaskScheduler.UnobservedTaskException += async (_, args) => + TaskScheduler.UnobservedTaskException += (_, args) => { - await serviceProvider - .GetRequiredService() - .GetEvent() - .PublishAsync(args.Exception); - serviceProvider.GetRequiredService().LogError(args.Exception, "Unobserved task exception"); - args.SetObserved(); + try + { + serviceProvider.GetRequiredService().CreateLogger("UnobservedTaskException") + .LogError(args.Exception, "Unobserved task exception"); + } +#pragma warning disable CA1031 + catch (Exception e) +#pragma warning restore CA1031 + { + Console.WriteLine("Error logging unobserved task exception"); + Console.WriteLine(args.Exception); + Console.WriteLine(e); + } + finally + { + args.SetObserved(); + } }; if (initializeDocumentStore) From a98d80eccb0c09eabff2093c37c391b6bafa68a2 Mon Sep 17 00:00:00 2001 From: Adam Hathcock Date: Thu, 30 Jan 2025 12:56:47 +0000 Subject: [PATCH 2/2] formatting --- DUI3/Speckle.Connectors.DUI/ContainerRegistration.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/DUI3/Speckle.Connectors.DUI/ContainerRegistration.cs b/DUI3/Speckle.Connectors.DUI/ContainerRegistration.cs index e7f706452..bf755059b 100644 --- a/DUI3/Speckle.Connectors.DUI/ContainerRegistration.cs +++ b/DUI3/Speckle.Connectors.DUI/ContainerRegistration.cs @@ -58,7 +58,9 @@ public static IServiceProvider UseDUI(this IServiceProvider serviceProvider, boo { try { - serviceProvider.GetRequiredService().CreateLogger("UnobservedTaskException") + serviceProvider + .GetRequiredService() + .CreateLogger("UnobservedTaskException") .LogError(args.Exception, "Unobserved task exception"); } #pragma warning disable CA1031