Revit Connector: Gutters not converted when sending "everything"

[ks-cph]

Prerequisites

• I read the contribution guidelines
• I checked the documentation and found no answer.
• I checked existing issues and found no similar issue.
• I checked the community forum for related discussions and found no answer.
• I'm reporting the issue to the correct repository (see also speckle-server, speckle-sharp, specklepy, speckle-docs, and others)

What package are you referring to?

Backend

Describe the bug

I am trying to send a model in Revit 2023 with roofs and gutters. When sending "everything", the gutters are not converted. However, when selecting them and sending "selection", they are converted correctly.

To Reproduce

Steps to reproduce the behavior:

1. Create a Revit model with gutters and roofs
2. Click on Send everything
3. Open the stream on Speckle
4. See that the gutters are missing

Expected behavior

We would expect the gutters also to be streamed when sending "everything"

Proposed Solution

The error is somewhere in ConnectorRevitUtils:

speckle-sharp/ConnectorRevit/ConnectorRevit/ConnectorRevitUtils.cs

Lines 70 to 75 in 149d35e

	//get elements of supported categories
	var categoryIds = cache
	.GetOrInitializeWithDefaultFactory<Category>()
	.GetAllObjects()
	.Select(category => category.Id)
	.ToList();

The category OST_Gutter has not been added. When manually adding OST_Gutter with the id -2001391, the Gutters are correctly converted even when sending "everything".

I do not understand what exactly is going on in GetOrInitializeWithDefaultFactory, so I can neither propose a solution.

[linear]

CNX-290 Revit Connector: Gutters not converted when sending "everything"

[ks-cph]

I noticed that the same behavior occurs for elements of the category Soffit and Fascia.

[martinromby]

Any guidance to how we better can understand GetOrInitializeWithDefaultFactory and propose a solution here @bimgeek ?

[clairekuang]

Do these element types not fall under the types of categories listed in this method? ->
https://github.com/specklesystems/speckle-sharp/blob/main/ConnectorRevit/RevitSharedResources/Helpers/Extensions.cs#L64

It may be that the category is not being registered as supported, see this line:

speckle-sharp/ConnectorRevit/RevitSharedResources/Extensions/SpeckleExtensions/IRevitDocumentAggregateCacheExtensions.cs

Line 51 in 429dcfd

if (!Helpers.Extensions.Extensions.IsCategorySupported(category))

[ks-cph]

They are exported when selected explicitly and sent by "Selection." So they should be supported, shouldn't they? The sending "forgets" them when sending "everything."