From d78228d28e67984d65ba5cc0e09749ddd59a7fed Mon Sep 17 00:00:00 2001 From: Isaac Garzon Date: Thu, 14 Jul 2022 13:55:56 +0300 Subject: [PATCH] mutable_db_options: fix a Clang 14 build error (#57) Clang 14 fails to compile with the following error: ``` options/db_options.h:120:21: error: definition of implicit copy constructor for 'MutableDBOptions' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy] MutableDBOptions& operator=(const MutableDBOptions&) = default; ^ db/compaction/compaction_job.cc:439:7: note: in implicit copy constructor for 'rocksdb::MutableDBOptions' first required here mutable_db_options_copy_(mutable_db_options), ^ ``` This is caused by the introduction of an assignment operator in #7 due to a diagnostic emitted by Clang 13 which isn't emitted by Clang 14, so this was probably a compiler bug, and we just need to remove the assignment operator. --- options/db_options.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/options/db_options.h b/options/db_options.h index 4c2589a735..a00399e677 100644 --- a/options/db_options.h +++ b/options/db_options.h @@ -117,8 +117,6 @@ struct MutableDBOptions { MutableDBOptions(); explicit MutableDBOptions(const DBOptions& options); - MutableDBOptions& operator=(const MutableDBOptions&) = default; - void Dump(Logger* log) const; int max_background_jobs;