Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize DNS client performance #357

Merged
merged 1 commit into from
May 24, 2023
Merged

optimize DNS client performance #357

merged 1 commit into from
May 24, 2023

Conversation

ii2day
Copy link
Member

@ii2day ii2day commented May 23, 2023

No description provided.

@ii2day ii2day requested a review from weizhoublue as a code owner May 23, 2023 12:15
@ii2day ii2day added enhancement New feature or request release/feature feature pr recoded in new release labels May 23, 2023
@ii2day ii2day force-pushed the dns_client branch 5 times, most recently from 77b1d56 to 05a90cd Compare May 23, 2023 13:01
Signed-off-by: ii2day <ji.li@daocloud.io>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #357 (e8c354c) into main (0a82158) will increase coverage by 10.04%.
The diff coverage is 94.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #357       +/-   ##
===========================================
+ Coverage   31.56%   41.61%   +10.04%     
===========================================
  Files           6        8        +2     
  Lines         453      495       +42     
===========================================
+ Hits          143      206       +63     
+ Misses        299      285       -14     
+ Partials       11        4        -7     
Flag Coverage Δ
unittests 41.61% <94.94%> (+10.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/loadRequest/loadDns/dns_reporter.go 85.71% <85.71%> (ø)
pkg/loadRequest/loadDns/dns.go 91.89% <93.33%> (+13.57%) ⬆️
pkg/loadRequest/loadDns/dns_requester.go 97.50% <97.50%> (ø)

@ii2day
Copy link
Member Author

ii2day commented May 23, 2023

"Detail": {
	"Detail": [
		{
			"FailureReason": "",
			"MeanDelay": 8.1,
			"Metrics": {
				"start": "2023-05-23T13:14:00.021766571Z",
				"end": "2023-05-23T13:14:10.040998222Z",
				"target_domain": "baidu.com.",
				"dns_server": "172.18.0.1:53",
				"Method": "udp",
				"duration": "10.019231651s",
				"requests": 100,
				"success": 100,
				"failed": 0,
				"TPS": 9.980805263647058,
				"latencies": {
					"Mean_inMs": 8.1,
					"P50_inMs": 7,
					"P90_inMs": 14,
					"P95_inMs": 14,
					"P99_inMs": 15,
					"Max_inMs": 15,
					"Min_inMs": 4
				},
				"errors": {},
				"reply_code": {
					"NOERROR": 100
				}
			},
			"Succeed": "true",
			"SucceedRate": "1",
			"TargetName": "typeA_172.18.0.1:53_baidu.com",
			"TargetProtocol": "udp",
			"TargetServer": "172.18.0.1:53"
		}
	],
	"FailureReason": "",
	"Succeed": "true",
	"TargetNumber": "1",
	"TargetType": "spiderdoctor agent"
}

@weizhoublue weizhoublue merged commit e7b0563 into main May 24, 2023
@weizhoublue weizhoublue deleted the dns_client branch May 24, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release/feature feature pr recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants