From 7defbbf42e48c517b7973a9a3ecb6a4027139cf2 Mon Sep 17 00:00:00 2001 From: cyclinder Date: Mon, 4 Dec 2023 17:28:01 +0800 Subject: [PATCH 1/2] coordinator: Detect gateway in pod's netns without in hostNs --- cmd/coordinator/cmd/command_add.go | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/cmd/coordinator/cmd/command_add.go b/cmd/coordinator/cmd/command_add.go index b9644abe77..53b0bebe37 100644 --- a/cmd/coordinator/cmd/command_add.go +++ b/cmd/coordinator/cmd/command_add.go @@ -6,6 +6,8 @@ package cmd import ( "context" "fmt" + "time" + "github.com/containernetworking/cni/pkg/skel" "github.com/containernetworking/cni/pkg/types" current "github.com/containernetworking/cni/pkg/types/100" @@ -13,7 +15,6 @@ import ( "github.com/vishvananda/netlink" "go.uber.org/zap" "golang.org/x/sync/errgroup" - "time" "github.com/spidernet-io/spiderpool/api/v1/agent/client/daemonset" "github.com/spidernet-io/spiderpool/api/v1/agent/models" @@ -162,21 +163,20 @@ func CmdAdd(args *skel.CmdArgs) (err error) { logger.Error("failed to GetDefaultGatewayByName", zap.Error(err)) return fmt.Errorf("failed to GetDefaultGatewayByName: %v", err) } + + logger.Debug("Get GetDefaultGatewayByName", zap.Strings("Gws", gws)) + for _, gw := range gws { + p, err := gwconnection.NewPinger(conf.DetectOptions.Retry, conf.DetectOptions.Interval, conf.DetectOptions.TimeOut, gw, logger) + if err != nil { + return fmt.Errorf("failed to run NewPinger: %v", err) + } + errg.Go(p.DetectGateway) + } return nil }) if err != nil { return err } - - logger.Debug("Get GetDefaultGatewayByName", zap.Strings("Gws", gws)) - - for _, gw := range gws { - p, err := gwconnection.NewPinger(conf.DetectOptions.Retry, conf.DetectOptions.Interval, conf.DetectOptions.TimeOut, gw, logger) - if err != nil { - return fmt.Errorf("failed to run NewPinger: %v", err) - } - errg.Go(p.DetectGateway) - } } else { logger.Debug("disable detect gateway") } @@ -194,7 +194,7 @@ func CmdAdd(args *skel.CmdArgs) (err error) { if err = errg.Wait(); err != nil { logger.Error("failed to ip checking", zap.Error(err)) - return fmt.Errorf("failed to ip checking: %w", err) + return err } // overwrite mac address From faa3809e1b8c0d728f420fd5ea53221ac4b68c40 Mon Sep 17 00:00:00 2001 From: cyclinder Date: Tue, 5 Dec 2023 10:22:31 +0800 Subject: [PATCH 2/2] init-pod: don't init multus CR if multus is disable --- cmd/spiderpool-init/cmd/root.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cmd/spiderpool-init/cmd/root.go b/cmd/spiderpool-init/cmd/root.go index 043872d97c..079568ef52 100644 --- a/cmd/spiderpool-init/cmd/root.go +++ b/cmd/spiderpool-init/cmd/root.go @@ -146,8 +146,10 @@ func Execute() { } } - if err = InitMultusDefaultCR(ctx, &config, client); err != nil { - logger.Fatal(err.Error()) + if config.enableMultusConfig { + if err = InitMultusDefaultCR(ctx, &config, client); err != nil { + logger.Fatal(err.Error()) + } } if err = makeReadinessReady(&config); err != nil {