Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod owner attributes for RDMA metrics #4294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Nov 18, 2024

No description provided.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 75.63025% with 29 lines in your changes missing coverage. Please review.

Project coverage is 79.55%. Comparing base (335952e) to head (93045fe).

Files with missing lines Patch % Lines
pkg/podownercache/pod_owner_cache.go 80.76% 14 Missing and 6 partials ⚠️
pkg/rdmametrics/metrics.go 40.00% 7 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4294      +/-   ##
==========================================
+ Coverage   79.51%   79.55%   +0.04%     
==========================================
  Files          53       54       +1     
  Lines        6252     6359     +107     
==========================================
+ Hits         4971     5059      +88     
- Misses       1088     1102      +14     
- Partials      193      198       +5     
Flag Coverage Δ
unittests 79.55% <75.63%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/rdmametrics/metrics.go 79.48% <40.00%> (+0.41%) ⬆️
pkg/podownercache/pod_owner_cache.go 80.76% <80.76%> (ø)
---- 🚨 Try these New Features:

@ty-dc
Copy link
Collaborator

ty-dc commented Nov 18, 2024

This problem #4293 seems to cause CI to fail

and the trivy images failed https://github.com/spidernet-io/spiderpool/actions/runs/11910688357/job/33237767686?pr=4294, please wait #4289

@lou-lan lou-lan force-pushed the update-metrics branch 2 times, most recently from 638d96a to c8de765 Compare November 19, 2024 09:20
@lou-lan lou-lan added release/feature-new release note for new feature and removed kind/feature labels Nov 19, 2024
@lou-lan lou-lan force-pushed the update-metrics branch 2 times, most recently from 59b290a to 0be0d4c Compare November 19, 2024 10:04
@lou-lan lou-lan force-pushed the update-metrics branch 3 times, most recently from cb6dc13 to 4eef3b3 Compare November 21, 2024 10:15
Signed-off-by: lou-lan <loulan@loulan.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/feature-new release note for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants