chore(build): Update Dockerfiles for new cloudbuild configs #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttomsu
reviewed
Feb 19, 2020
Dockerfile.compile
Outdated
| && apt-get install -y \ | ||
| openjdk-8-jdk-headless \ | ||
| && apt-get clean |
There was a problem hiding this comment.
In the past, we've had flaky container builds doing an apt upgrade, not to mention that it takes a relatively long time. Since this is only an intermediate container, what do you think about simply basing it FROM openjdk:8, just like Dockerfile.java8?
There was a problem hiding this comment.
Ooh, yeah, I forgot about those. That's way better, thanks. I'll work on updating all the PRs, make sure they still build, and then update this comment when I'm done.
There was a problem hiding this comment.
They all compiled fine with openjdk:8, so I've updated all 10 of the PRs whenever you get a chance to review, thanks.
ttomsu
approved these changes
Feb 19, 2020
plumpy
force-pushed
the
container_builds
branch
from
0a2a3a0 to
a21d8c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See spinnaker/buildtool#14