Add connection Credentials to StorageLocation #743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizardoluis
force-pushed
the
storage-location-info
branch
from
a4074f5 to
af4821f
Compare
lizardoluis
force-pushed
the
storage-location-info
branch
from
a27d7aa to
91ffb6e
Compare
lizardoluis
requested review from
gruuya,
mildbyte and
SergeiPatiakin
and removed request for
mildbyte
gruuya
reviewed
Nov 22, 2024
There was a problem hiding this comment.
I'm not sure I follow why we need to separate out the credentials in the first place? In this way we add some friction to the API, with one having to delineate what is an option and what is a credential (whereas downstream crates, such as object_store and iceberg rust storage treat them the same).
Since they end up in the same place anyway why just not simply merge the two maps prior to calling build_object_store_from_opts/S3config::from_hashmap and leave the object_store_factory as is?
Comment on lines
+265
to
268
| options.insert( | ||
| "google_service_account".to_string(), | ||
| "my_google_service_account".to_string(), | ||
| ); |
There was a problem hiding this comment.
Shouldn't this be in credentials now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the field
credentialsto theStorageLocationInfo. The credentials will be stored using user mappings, therefore I needed to separate them fromoptions. Other changes include renaming the struct in cladeStorageLocation::locationtoStorageLocation::url, which matches the naming we are using throughout the system.