refactor: move startingUp flag update after store in mySegmentsUpdater

Author: EmilianoSanchez

src/storages/inLocalStorage/MySegmentsCacheInLocal.ts

@@ -2,10 +2,8 @@ import { ILogger } from '../../logger/types';
 import { isNaNNumber } from '../../utils/lang';
 import { AbstractMySegmentsCacheSync } from '../AbstractMySegmentsCacheSync';
 import type { MySegmentsKeyBuilder } from '../KeyBuilderCS';
-import { LOG_PREFIX, DEFINED } from './constants';
+import { DEFINED } from './constants';
 import { StorageAdapter } from '../types';
-import { MySegmentsData } from '../../sync/polling/types';
-import { IMySegmentsResponse } from '../../dtos/types';
 
 export class MySegmentsCacheInLocal extends AbstractMySegmentsCacheSync {
 
@@ -71,13 +69,4 @@ export class MySegmentsCacheInLocal extends AbstractMySegmentsCacheSync {
     return n;
   }
 
-  resetSegments(segmentsData: MySegmentsData | IMySegmentsResponse) {
-    try {
-      return super.resetSegments(segmentsData);
-    } catch (e) {
-      this.log.error(LOG_PREFIX + e);
-      return false;
-    }
-  }
-
 }

src/storages/inLocalStorage/__tests__/MySegmentsCacheInLocal.spec.ts

@@ -39,16 +39,3 @@ test.each(storages)('SEGMENT CACHE / in LocalStorage', (storage) => {
   expect(storage.getItem(PREFIX + '.user.largeSegment.mocked-segment-2')).toBe('1');
   expect(storage.getItem(PREFIX + '.user.largeSegment.mocked-segment')).toBe(null);
 });
-
-test('SEGMENT CACHE / Special case: localStorage failure should not throw an exception', () => {
-  const cache = new MySegmentsCacheInLocal(loggerMock, new KeyBuilderCS(PREFIX, 'user2'), localStorage);
-
-  // mock localStorage failure
-  const setItemSpy = jest.spyOn(localStorage, 'setItem').mockImplementation(() => { throw new Error('localStorage failure'); });
-  setItemSpy.mockClear();
-
-  expect(cache.resetSegments({ k: [{ n: 'mocked-segment' }, { n: 'mocked-segment-2' }], cn: 123 })).toBe(false);
-  expect(setItemSpy).toHaveBeenCalledTimes(1);
-
-  setItemSpy.mockRestore();
-});

src/sync/polling/updaters/mySegmentsUpdater.ts

@@ -66,10 +66,10 @@ export function mySegmentsUpdaterFactory(
       new Promise((res) => { updateSegments(segmentsData); res(true); }) :
       // If not provided, fetch mySegments
       mySegmentsFetcher(matchingKey, noCache, till, _promiseDecorator).then(segments => {
-        // Only when we have downloaded segments completely, we should not keep retrying anymore
-        startingUp = false;
-
         updateSegments(segments);
+
+        // Only when we have downloaded and stored segments completely, we should not keep retrying anymore
+        startingUp = false;
         return true;
       });