Making password extraction more robust #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwang92
requested review from
alishamayor,
arctan5x,
hendolim,
jmeixensperger,
jonathan-vega-splunk,
jrigassio-splunk and
lephino
as code owners
alishamayor
approved these changes
Apr 14, 2020
jrigassio-splunk
approved these changes
Apr 15, 2020
Contributor
|
we could probably make password extraction its own function at some point, seeing as it's the same regex line a dozen times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think one of my last PRs that added a new
passwordfield may have broken the weak regex used to find the randomly-generated password here.Hopefully this one is more robust to future changes - although maybe we should be doing this in a better way.