Add milliseconds to SQLite datetimes #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SQLite DATETIME() method does not provide milliseconds nor has a switch for toggling them. This is overall inconvenient. By calling correctly STRFTIME(), we can have the milliseconds information appropriately added. In addition, the CI configuration file was updated to support newer Python and SQLAlchemy versions.
dahlia
reviewed
Jun 21, 2021
|
I can definitely do that! How much of an overhead should I have? 0.5 seconds? |
- Tox environments for newer Python versions have been added - Big improvements in Travis CI - Not testing agains EOL SQLAlchemy 0.9 - Fetch correct dependencies versions for older Python envs - Temporarily adjust the README for my personal branch, plus point to newer Travis CI (from .org it has unified in .com)
- Avoid testing older Python versions with SQLAlchemy v1.4 as no package is available for them - Resolve the issue with the newer `pytest-cov` not working with older `pytest` by installing an older version where necessary
The double square brackets in Bash uses '&&' while the single square brackets uses '-a'. I essentially used the wrong convention here :P
dahlia
reviewed
Jun 24, 2021
Travis-CI can still keep up even on unsupported Python versions. Just mention that those are unsupported and add references so that in the future the deprecated versions can be removed easily. Also, restore CI links to the official project.
|
Hi, is there any issue with the current pull request? |
dahlia
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
It looks good to me. @pbzweihander could you please take a look?
pbzweihander
approved these changes
Sep 22, 2021
|
@Jhuni0123 Could you review and merge this PR? |
Jhuni0123
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQLite DATETIME() method does not provide milliseconds nor has a switch for toggling them.
This is overall inconvenient.
By calling correctly STRFTIME(), we can have the milliseconds information appropriately added.
In addition, the CI configuration file was updated to support newer Python and SQLAlchemy versions.