Drop support for EOL Python versions, add 3.6, fix failing tests. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
suggested changes
Jan 19, 2018
.travis.yml
Outdated
| - if [[ "$PY_VER" != "3.2" ]]; then | ||
| codecov; | ||
| fi | ||
| - codecov |
There was a problem hiding this comment.
Could you maintain the style as it was as possible (such as no indent for list bullets)? The diff is unnecessarily complex so that I could hardly track the actual changes.
sqlalchemy_utc.py
Outdated
| @@ -3,7 +3,7 @@ | |||
| from sqlalchemy.types import DateTime, TypeDecorator | |||
|
|
|||
| __all__ = 'UtcDateTime', '__version__' | |||
| __version__ = '0.9.0' | |||
| __version__ = '0.9.1' | |||
There was a problem hiding this comment.
If we're going to drop older versions of Python and SQLAlchemy we'd better bump its minor version, i.e., 0.10.0 instead of 0.9.1.
gwax
force-pushed
the
updated_versions
branch
from
57460e5 to
79cb05b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 1 1
Lines 29 29
=======================================
Hits 28 28
Misses 1 1
Continue to review full report at Codecov.
|
gwax
force-pushed
the
updated_versions
branch
2 times, most recently
from
6b6bd6f to
9b8301d
Compare
gwax
force-pushed
the
updated_versions
branch
from
9b8301d to
18cdc56
Compare
dahlia
approved these changes
Jan 20, 2018
|
Thanks! |
dahlia
added a commit
that referenced
this pull request
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some features that I would like to contribute to your package for use downstream. This PR updates the versions of Python and other libraries used in testing and adjusts how tests are performed. This PR does not change package functionality.