Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the following headers to API server requests:
Access-Control-Allow-Headers:Accept, Authorization, Content-Type, Origin
Access-Control-Allow-Methods:GET, OPTIONS
Access-Control-Allow-Origin:*
Motivation and Context
This allows an external application to request data from the api via Javascript. In our specific case, we request JSON data from
/api/graph
and display it in an internal ops dashboard.Have you tested this? If so, how?
Ran the server locally and verified that the desired headers show up. Tested out with an AngularJS application that pulls in luigi task data.
Simple test that you can run in a dev console (requires jQuery):
$.get("http://localhost:8082/api/graph", function(data) { console.dir(data.response); })