Skip to content

Commit a570d7a

Browse files
committed
Polishing.
Replace test usage of SimpleMetadataReaderFactory with MetadataReaderFactory.create(…). See #3402
1 parent 128e1a0 commit a570d7a

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

src/test/java/org/springframework/data/repository/config/CustomRepositoryImplementationDetectorUnitTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@
2424
import org.junit.jupiter.api.BeforeEach;
2525
import org.junit.jupiter.api.Test;
2626
import org.mockito.Answers;
27+
2728
import org.springframework.beans.factory.config.BeanDefinition;
2829
import org.springframework.core.env.Environment;
2930
import org.springframework.core.io.DefaultResourceLoader;
3031
import org.springframework.core.io.ResourceLoader;
3132
import org.springframework.core.type.classreading.MetadataReaderFactory;
32-
import org.springframework.core.type.classreading.SimpleMetadataReaderFactory;
3333
import org.springframework.data.repository.config.CustomRepositoryImplementationDetectorUnitTests.First.CanonicalSampleRepositoryTestImpl;
3434
import org.springframework.data.util.Streamable;
3535
import org.springframework.mock.env.MockEnvironment;
@@ -42,7 +42,7 @@
4242
*/
4343
class CustomRepositoryImplementationDetectorUnitTests {
4444

45-
MetadataReaderFactory metadataFactory = new SimpleMetadataReaderFactory();
45+
MetadataReaderFactory metadataFactory = MetadataReaderFactory.create(getClass().getClassLoader());
4646
Environment environment = new MockEnvironment();
4747
ResourceLoader resourceLoader = new DefaultResourceLoader();
4848
ImplementationDetectionConfiguration configuration = mock(ImplementationDetectionConfiguration.class,

src/test/java/org/springframework/data/repository/config/ImplementationDetectionConfigurationUnitTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import org.junit.jupiter.api.Test;
2121
import org.springframework.beans.factory.support.BeanDefinitionBuilder;
2222
import org.springframework.core.type.classreading.MetadataReaderFactory;
23-
import org.springframework.core.type.classreading.SimpleMetadataReaderFactory;
2423
import org.springframework.core.type.filter.TypeFilter;
2524
import org.springframework.data.util.Streamable;
2625

@@ -65,7 +64,7 @@ public Streamable<TypeFilter> getExcludeFilters() {
6564

6665
@Override
6766
public MetadataReaderFactory getMetadataReaderFactory() {
68-
return new SimpleMetadataReaderFactory();
67+
return MetadataReaderFactory.create(getClass().getClassLoader());
6968
}
7069
}
7170
}

src/test/java/org/springframework/data/repository/config/RepositoryBeanNameGeneratorUnitTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.springframework.context.annotation.AnnotationBeanNameGenerator;
3232
import org.springframework.context.annotation.ScannedGenericBeanDefinition;
3333
import org.springframework.core.type.classreading.MetadataReaderFactory;
34-
import org.springframework.core.type.classreading.SimpleMetadataReaderFactory;
3534
import org.springframework.data.repository.core.support.RepositoryFactoryBeanSupport;
3635

3736
/**
@@ -68,7 +67,7 @@ void usesAnnotationValueIfAnnotationPresent() {
6867
@Test // DATACMNS-1115
6968
void usesClassNameOfScannedBeanDefinition() throws IOException {
7069

71-
MetadataReaderFactory factory = new SimpleMetadataReaderFactory();
70+
MetadataReaderFactory factory = MetadataReaderFactory.create(getClass().getClassLoader());
7271
var reader = factory.getMetadataReader(SomeImplementation.class.getName());
7372

7473
BeanDefinition definition = new ScannedGenericBeanDefinition(reader);

0 commit comments

Comments
 (0)