Polishing

Author: jhoeller

spring-core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java

@@ -401,6 +401,7 @@ public static <A extends Annotation> Set<A> getRepeatableAnnotations(AnnotatedEl
 	 */
 	public static <A extends Annotation> Set<A> getDeclaredRepeatableAnnotations(AnnotatedElement annotatedElement,
 			Class<A> annotationType) {
+
 		return getDeclaredRepeatableAnnotations(annotatedElement, annotationType, null);
 	}
 
@@ -435,6 +436,7 @@ public static <A extends Annotation> Set<A> getDeclaredRepeatableAnnotations(Ann
 	 */
 	public static <A extends Annotation> Set<A> getDeclaredRepeatableAnnotations(AnnotatedElement annotatedElement,
 			Class<A> annotationType, Class<? extends Annotation> containerAnnotationType) {
+
 		return getRepeatableAnnotations(annotatedElement, annotationType, containerAnnotationType, true);
 	}
 
@@ -496,7 +498,7 @@ public static <A extends Annotation> A findAnnotation(AnnotatedElement annotated
 		// Do NOT store result in the findAnnotationCache since doing so could break
 		// findAnnotation(Class, Class) and findAnnotation(Method, Class).
 		return synthesizeAnnotation(findAnnotation(annotatedElement, annotationType, new HashSet<Annotation>()),
-			annotatedElement);
+				annotatedElement);
 	}
 
 	/**
@@ -957,6 +959,7 @@ public static Map<String, Object> getAnnotationAttributes(Annotation annotation,
 	 */
 	public static AnnotationAttributes getAnnotationAttributes(Annotation annotation, boolean classValuesAsString,
 			boolean nestedAnnotationsAsMap) {
+
 		return getAnnotationAttributes(null, annotation, classValuesAsString, nestedAnnotationsAsMap);
 	}
 
@@ -1396,7 +1399,6 @@ public static Annotation[] synthesizeAnnotationArray(Annotation[] annotations, A
 	@SuppressWarnings("unchecked")
 	static <A extends Annotation> A[] synthesizeAnnotationArray(Map<String, Object>[] maps, Class<A> annotationType) {
 		Assert.notNull(annotationType, "annotationType must not be null");
-
 		if (maps == null) {
 			return null;
 		}
@@ -1478,7 +1480,8 @@ private static boolean isSynthesizable(Class<? extends Annotation> annotationTyp
 			}
 			Class<?> returnType = attribute.getReturnType();
 			if (Annotation[].class.isAssignableFrom(returnType)) {
-				Class<? extends Annotation> nestedAnnotationType = (Class<? extends Annotation>) returnType.getComponentType();
+				Class<? extends Annotation> nestedAnnotationType =
+						(Class<? extends Annotation>) returnType.getComponentType();
 				if (isSynthesizable(nestedAnnotationType)) {
 					synthesizable = Boolean.TRUE;
 					break;
@@ -1512,7 +1515,6 @@ else if (Annotation.class.isAssignableFrom(returnType)) {
 	 */
 	static List<String> getAttributeAliasNames(Method attribute) {
 		Assert.notNull(attribute, "attribute must not be null");
-
 		AliasDescriptor descriptor = AliasDescriptor.from(attribute);
 		return (descriptor == null ? Collections.<String> emptyList() : descriptor.getAttributeAliasNames());
 	}
@@ -1537,10 +1539,10 @@ static String getAttributeOverrideName(Method attribute, Class<? extends Annotat
 		Assert.notNull(attribute, "attribute must not be null");
 		Assert.notNull(metaAnnotationType, "metaAnnotationType must not be null");
 		Assert.isTrue(!Annotation.class.equals(metaAnnotationType),
-			"metaAnnotationType must not be java.lang.annotation.Annotation");
+				"metaAnnotationType must not be [java.lang.annotation.Annotation]");
 
 		AliasDescriptor descriptor = AliasDescriptor.from(attribute);
-		return (descriptor == null ? null : descriptor.getAttributeOverrideName(metaAnnotationType));
+		return (descriptor != null ? descriptor.getAttributeOverrideName(metaAnnotationType) : null);
 	}
 
 	/**
@@ -1668,10 +1670,10 @@ static void postProcessAnnotationAttributes(AnnotatedElement element, Annotation
 					if (valuePresent && aliasPresent) {
 						// Since annotation attributes can be arrays, we must use ObjectUtils.nullSafeEquals().
 						if (!ObjectUtils.nullSafeEquals(value, aliasedValue)) {
-							String elementAsString = (element == null ? "unknown element" : element.toString());
-							String msg = String.format("In AnnotationAttributes for annotation [%s] declared on [%s], "
-									+ "attribute [%s] and its alias [%s] are declared with values of [%s] and [%s], "
-									+ "but only one declaration is permitted.", annotationType.getName(),
+							String elementAsString = (element != null ? element.toString() : "unknown element");
+							String msg = String.format("In AnnotationAttributes for annotation [%s] declared on [%s], " +
+									"attribute [%s] and its alias [%s] are declared with values of [%s] and [%s], " +
+									"but only one declaration is permitted.", annotationType.getName(),
 									elementAsString, attributeName, aliasedAttributeName,
 									ObjectUtils.nullSafeToString(value), ObjectUtils.nullSafeToString(aliasedValue));
 							throw new AnnotationConfigurationException(msg);
@@ -1680,13 +1682,13 @@ static void postProcessAnnotationAttributes(AnnotatedElement element, Annotation
 					else if (aliasPresent) {
 						// Replace value with aliasedValue
 						attributes.put(attributeName,
-							adaptValue(element, aliasedValue, classValuesAsString, nestedAnnotationsAsMap));
+								adaptValue(element, aliasedValue, classValuesAsString, nestedAnnotationsAsMap));
 						valuesAlreadyReplaced.add(attributeName);
 					}
 					else {
 						// Replace aliasedValue with value
 						attributes.put(aliasedAttributeName,
-							adaptValue(element, value, classValuesAsString, nestedAnnotationsAsMap));
+								adaptValue(element, value, classValuesAsString, nestedAnnotationsAsMap));
 						valuesAlreadyReplaced.add(aliasedAttributeName);
 					}
 				}
@@ -1712,7 +1714,7 @@ else if (aliasPresent) {
 	 * it will be cast to an {@code AnnotationConfigurationException} and thrown,
 	 * allowing it to propagate to the caller.
 	 * <p>Otherwise, this method does nothing.
-	 * @param t the throwable to inspect
+	 * @param ex the throwable to inspect
 	 * @since 4.2
 	 */
 	static void rethrowAnnotationConfigurationException(Throwable ex) {
@@ -1874,6 +1876,7 @@ private List<A> getValue(AnnotatedElement element, Annotation annotation) {
 		}
 	}
 
+
 	/**
 	 * {@code AliasDescriptor} encapsulates the declaration of {@code @AliasFor}
 	 * on a given annotation attribute and includes support for validating
@@ -1899,7 +1902,6 @@ private static class AliasDescriptor {
 
 		private final boolean isAliasPair;
 
-
 		/**
 		 * Create an {@code AliasDescriptor} <em>from</em> the declaration
 		 * of {@code @AliasFor} on the supplied annotation attribute and
@@ -1936,60 +1938,59 @@ private AliasDescriptor(Method sourceAttribute, AliasFor aliasFor) {
 			this.sourceAnnotationType = (Class<? extends Annotation>) declaringClass;
 			this.sourceAttributeName = this.sourceAttribute.getName();
 
-			this.aliasedAnnotationType = (Annotation.class.equals(aliasFor.annotation()) ? this.sourceAnnotationType
-					: aliasFor.annotation());
+			this.aliasedAnnotationType = (Annotation.class.equals(aliasFor.annotation()) ?
+					this.sourceAnnotationType : aliasFor.annotation());
 			this.aliasedAttributeName = getAliasedAttributeName(aliasFor, this.sourceAttribute);
 			try {
 				this.aliasedAttribute = this.aliasedAnnotationType.getDeclaredMethod(this.aliasedAttributeName);
 			}
 			catch (NoSuchMethodException ex) {
 				String msg = String.format(
-					"Attribute [%s] in annotation [%s] is declared as an @AliasFor nonexistent attribute [%s] in annotation [%s].",
-					this.sourceAttributeName, this.sourceAnnotationType.getName(), this.aliasedAttributeName,
-					this.aliasedAnnotationType.getName());
+						"Attribute [%s] in annotation [%s] is declared as an @AliasFor nonexistent attribute [%s] in annotation [%s].",
+						this.sourceAttributeName, this.sourceAnnotationType.getName(), this.aliasedAttributeName,
+						this.aliasedAnnotationType.getName());
 				throw new AnnotationConfigurationException(msg, ex);
 			}
 
 			this.isAliasPair = this.sourceAnnotationType.equals(this.aliasedAnnotationType);
 		}
 
 		private void validate() {
-
 			// Target annotation is not meta-present?
 			if (!this.isAliasPair && !isAnnotationMetaPresent(this.sourceAnnotationType, this.aliasedAnnotationType)) {
-				String msg = String.format("@AliasFor declaration on attribute [%s] in annotation [%s] declares "
-					+ "an alias for attribute [%s] in meta-annotation [%s] which is not meta-present.",
-					this.sourceAttributeName, this.sourceAnnotationType.getName(), this.aliasedAttributeName,
-					this.aliasedAnnotationType.getName());
+				String msg = String.format("@AliasFor declaration on attribute [%s] in annotation [%s] declares " +
+						"an alias for attribute [%s] in meta-annotation [%s] which is not meta-present.",
+						this.sourceAttributeName, this.sourceAnnotationType.getName(), this.aliasedAttributeName,
+						this.aliasedAnnotationType.getName());
 				throw new AnnotationConfigurationException(msg);
 			}
 
 			if (this.isAliasPair) {
 				AliasFor mirrorAliasFor = this.aliasedAttribute.getAnnotation(AliasFor.class);
 				if (mirrorAliasFor == null) {
 					String msg = String.format(
-						"Attribute [%s] in annotation [%s] must be declared as an @AliasFor [%s].",
-						this.aliasedAttributeName, this.sourceAnnotationType.getName(), this.sourceAttributeName);
+							"Attribute [%s] in annotation [%s] must be declared as an @AliasFor [%s].",
+							this.aliasedAttributeName, this.sourceAnnotationType.getName(), this.sourceAttributeName);
 					throw new AnnotationConfigurationException(msg);
 				}
 
 				String mirrorAliasedAttributeName = getAliasedAttributeName(mirrorAliasFor, this.aliasedAttribute);
 				if (!this.sourceAttributeName.equals(mirrorAliasedAttributeName)) {
 					String msg = String.format(
-						"Attribute [%s] in annotation [%s] must be declared as an @AliasFor [%s], not [%s].",
-						this.aliasedAttributeName, this.sourceAnnotationType.getName(), this.sourceAttributeName,
-						mirrorAliasedAttributeName);
+							"Attribute [%s] in annotation [%s] must be declared as an @AliasFor [%s], not [%s].",
+							this.aliasedAttributeName, this.sourceAnnotationType.getName(), this.sourceAttributeName,
+							mirrorAliasedAttributeName);
 					throw new AnnotationConfigurationException(msg);
 				}
 			}
 
 			Class<?> returnType = this.sourceAttribute.getReturnType();
 			Class<?> aliasedReturnType = this.aliasedAttribute.getReturnType();
 			if (!returnType.equals(aliasedReturnType)) {
-				String msg = String.format("Misconfigured aliases: attribute [%s] in annotation [%s] "
-					+ "and attribute [%s] in annotation [%s] must declare the same return type.",
-					this.sourceAttributeName, this.sourceAnnotationType.getName(), this.aliasedAttributeName,
-					this.aliasedAnnotationType.getName());
+				String msg = String.format("Misconfigured aliases: attribute [%s] in annotation [%s] " +
+						"and attribute [%s] in annotation [%s] must declare the same return type.",
+						this.sourceAttributeName, this.sourceAnnotationType.getName(), this.aliasedAttributeName,
+						this.aliasedAnnotationType.getName());
 				throw new AnnotationConfigurationException(msg);
 			}
 
@@ -2003,19 +2004,19 @@ private void validateDefaultValueConfiguration(Method aliasedAttribute) {
 			Object defaultValue = this.sourceAttribute.getDefaultValue();
 			Object aliasedDefaultValue = aliasedAttribute.getDefaultValue();
 
-			if ((defaultValue == null) || (aliasedDefaultValue == null)) {
-				String msg = String.format("Misconfigured aliases: attribute [%s] in annotation [%s] "
-					+ "and attribute [%s] in annotation [%s] must declare default values.",
-					this.sourceAttributeName, this.sourceAnnotationType.getName(), aliasedAttribute.getName(),
-					aliasedAttribute.getDeclaringClass().getName());
+			if (defaultValue == null || aliasedDefaultValue == null) {
+				String msg = String.format("Misconfigured aliases: attribute [%s] in annotation [%s] " +
+						"and attribute [%s] in annotation [%s] must declare default values.",
+						this.sourceAttributeName, this.sourceAnnotationType.getName(), aliasedAttribute.getName(),
+						aliasedAttribute.getDeclaringClass().getName());
 				throw new AnnotationConfigurationException(msg);
 			}
 
 			if (!ObjectUtils.nullSafeEquals(defaultValue, aliasedDefaultValue)) {
-				String msg = String.format("Misconfigured aliases: attribute [%s] in annotation [%s] "
-					+ "and attribute [%s] in annotation [%s] must declare the same default value.",
-					this.sourceAttributeName, this.sourceAnnotationType.getName(), aliasedAttribute.getName(),
-					aliasedAttribute.getDeclaringClass().getName());
+				String msg = String.format("Misconfigured aliases: attribute [%s] in annotation [%s] " +
+						"and attribute [%s] in annotation [%s] must declare the same default value.",
+						this.sourceAttributeName, this.sourceAnnotationType.getName(), aliasedAttribute.getName(),
+						aliasedAttribute.getDeclaringClass().getName());
 				throw new AnnotationConfigurationException(msg);
 			}
 		}
@@ -2094,7 +2095,7 @@ private List<AliasDescriptor> getOtherDescriptors() {
 		public String getAttributeOverrideName(Class<? extends Annotation> metaAnnotationType) {
 			Assert.notNull(metaAnnotationType, "metaAnnotationType must not be null");
 			Assert.isTrue(!Annotation.class.equals(metaAnnotationType),
-				"metaAnnotationType must not be java.lang.annotation.Annotation");
+					"metaAnnotationType must not be [java.lang.annotation.Annotation]");
 
 			// Search the attribute override hierarchy, starting with the current attribute
 			for (AliasDescriptor desc = this; desc != null; desc = desc.getAttributeOverrideDescriptor()) {
@@ -2146,8 +2147,8 @@ private static String getAliasedAttributeName(AliasFor aliasFor, Method attribut
 			// Ensure user did not declare both 'value' and 'attribute' in @AliasFor
 			if (attributeDeclared && valueDeclared) {
 				throw new AnnotationConfigurationException(String.format(
-					"In @AliasFor declared on attribute [%s] in annotation [%s], attribute 'attribute' and its alias 'value' "
-							+ "are present with values of [%s] and [%s], but only one is permitted.",
+					"In @AliasFor declared on attribute [%s] in annotation [%s], attribute 'attribute' and its " +
+					"alias 'value' are present with values of [%s] and [%s], but only one is permitted.",
 					attribute.getName(), attribute.getDeclaringClass().getName(), attributeName, value));
 			}
 
@@ -2156,8 +2157,8 @@ private static String getAliasedAttributeName(AliasFor aliasFor, Method attribut
 			// Ensure user declared either 'value' or 'attribute' in @AliasFor
 			if (!StringUtils.hasText(attributeName)) {
 				String msg = String.format(
-					"@AliasFor declaration on attribute [%s] in annotation [%s] is missing required 'attribute' value.",
-					attribute.getName(), attribute.getDeclaringClass().getName());
+						"@AliasFor declaration on attribute [%s] in annotation [%s] is missing required 'attribute' value.",
+						attribute.getName(), attribute.getDeclaringClass().getName());
 				throw new AnnotationConfigurationException(msg);
 			}