Add support for the HTTP PATCH method [SPR-7985]

[spring-projects-issues]

Dirk Lachowski opened SPR-7985 and commented

As of March 2010 the http-verb PATCH has become an official method (see http://tools.ietf.org/html/rfc5789 ). It would be beneficial for REST-based services to be able to use this method.

---

Affects: 3.0.5

Issue Links:

• Allow DispatcherServlet/ServletWrappingController to work with the extended WebDAV methods [SPR-4799] #9476 Allow DispatcherServlet/ServletWrappingController to work with the extended WebDAV methods

Referenced from: commits 4623568, a074745, f265347

5 votes, 5 watchers

[spring-projects-issues]

Les Hazlewood commented

I'd like to second this request - we require this to support an upcoming specification that mandates the support of PATCH requests.

Is there a workaround until this is added?

[spring-projects-issues]

Christoffer Magnussen commented

I agree with Dirk and Les. PATCH support is needed for MVC to support REST-based services. It would be nice to see this marked for some later fix version.

[spring-projects-issues]

Trevor Mack commented

I also echo both Les and Christoffer, since HTTP/PATCH has been added as an official method (again) it would be nice to have this reflected in a future version of MVC so I don't have to overload the HTTP/PUT method calls.

[spring-projects-issues]

Rossen Stoyanchev commented

@Trevor and everyone else, is there anything beyond adding it to RequestMethod enum that you would like to see?

[spring-projects-issues]

Dirk Lachowski commented

Yes, beyond extending RequestMethod the service(HttpRequest, HttpResponse) method from HttpServlet has also to be overidden (i think in FrameworkServlet). FrameworkServlet overrides the HttpServlet do<Get, Post, ...> methods that are called from the HttpServlet service method - and there is no mapping for Patch. Then you need a doPatch method (in FrameworkServlet) that's called from the overriden service()-method.

[spring-projects-issues]

Rossen Stoyanchev commented

Thanks Dirk. Yes, the HttpServlet's service(..) method would need to be extended to include PATCH as one of the supported methods.

[spring-projects-issues]

Brian Clozel commented

What about org.springframework.web.client.RestTemplate and org.springframework.http.HttpMethod ?
Do these files fit in that scope or should we open another issue?

[spring-projects-issues]

Rossen Stoyanchev commented

I updated the title to be more descriptive (was: "Add RequestMethod.PATCH"). I think this ticket is fine. We'll add sub-tasks if necessary.

[spring-projects-issues]

Rossen Stoyanchev commented

I've created HTTPCLIENT-1191 in the issue tracker of Apache HttpClient. You can vote and put a watch on it.

[spring-projects-issues]

Rossen Stoyanchev commented

This is now resolved. In terms of client support, Apache HttpComponents HttpClient 4.2 or higher is required. The JDK HttpURLConnection does not support this method.

[spring-projects-issues]

Phil Webb commented

Reopening issue as doOptions() needs to be updated to add PATCH to the return (see HttpServlet.doOptions())