ScriptTemplateView should close the template InputStream [SPR-13445]

[spring-projects-issues]

Sébastien Deleuze opened SPR-13445 and commented

Running some benchmarks on spring-boot-sample-web-handlebars demo application then running lsof command line tool shows a lot of template files opened.

ScriptTemplateView#getTemplate() should close the template InputStream properly, since according to its Javadoc, StreamUtils#copyToString leaves the stream open when done.

---

Affects: 4.2.1

Referenced from: commits ff02ad4

[spring-projects-issues]

Sébastien Deleuze commented

This commit (not yet merged in master) fixes the issue

[spring-projects-issues]

Juergen Hoeller commented

Sébastien Deleuze, you could also FileCopyUtils.copyToString there, since that one does close the stream eventually. StreamUtils has been introduced as a kind of mirror class that explicitly does not close the stream for each of the operations.

Juergen

[spring-projects-issues]

Sébastien Deleuze commented

Indeed, thanks for your feedback!