Potential double invocation of getMissingCache in AbstractCacheManager [SPR-13492]

[spring-projects-issues]

Todd Lindner opened SPR-13492 and commented

AbstractCacheManager.getCache(String name) creates caches lazily on access. If the same cache is requested in two different threads it is possible for getMissingCache(name) to be invoked twice.

Suggestion is to add a double-lock mechanism when lookupCache(name) returns null.

---

Affects: 4.1.7

Issue Links:

• Properly wrap runtime-registered caches with TransactionAwareCacheDecorator [SPR-11518] #16143 Properly wrap runtime-registered caches with TransactionAwareCacheDecorator

Referenced from: commits 75ea6f5

[spring-projects-issues]

Juergen Hoeller commented

Indeed, under this race condition, application code may potentially be using two different Cache references for the same cache, depending on when the getCache calls happened.

I've revised AbstractCacheManager overall for consistent locking when caches get added, in particular also managing the cacheNames Set more defensively in such a scenario.

Juergen

[spring-projects-issues]

Todd Lindner commented

Thanks

[spring-projects-issues]

Juergen Hoeller commented

Note that due to the potential implications of the additional locking here, I'm leaving this as a 4.2.2 only change, not backporting it to 4.1.8.

Juergen