InMemoryWebSessionStore method to access map of sessions [SPR-16713]

[spring-projects-issues]

Jan Truksa opened SPR-16713 and commented

Would it be possible to have in org.springframework.web.server.session.WebSessionStore method like:

Mono<Map<String, WebSession>> getSessions()

With default implementation like:

public Mono<Map<String, WebSession>> getSessions() {
	return Mono.just(Collections.unmodifiableMap(sessions));
}

The thing I'm going to do is simple session management like list all active sessions, manually invalidate session by admin, etc. Obviously, I can just re-implement some implementation of WebSessionStore like InMemoryWebSessionStore and use this implementation in my application, but I would appreciate some native support.

On the other hand is it even good practice to expose sessions like this, when there isn't native support?

---

Affects: 5.0.7

Issue Links:

• InMemoryWebSessionStore could leak memory if sessions created but never used [SPR-17020] #21558 InMemoryWebSessionStore could leak memory if sessions created but never used

Referenced from: commits 6218db9, 43fbd63

[spring-projects-issues]

Rossen Stoyanchev commented

This should be possible and straight-forward for the InMemoryWebSessionStore although I would perhaps expose as Flux<WebSession> which is then easy to collect to a map anyway.

Rob Winch any further considerations from the perspective of alternative implementations?

[spring-projects-issues]

Rob Winch commented

I'm not very keen on supporting a findAll method. In large scale deployments there are going to be lots of sessions. You probably need a method that supports paging.

My general thoughts on this are the framework should only have methods that it requires and if users need additional methods, it is fairly trivial to support with Spring Data.

[spring-projects-issues]

Rossen Stoyanchev commented

Rob Winch can you elaborate on support for paging and on support with Spring Data, especially as it relates to what's available in Spring Session?

In the Spring Framework where we only have the InMemoryWebSessionStore, which arguably is a very different case (and for example does not require paging), we could expose the underlying map of sessions, i.e. without changing the WebSession contract, and leave it to Spring Session to expose whatever mechanisms it sees fit.

[spring-projects-issues]

Rossen Stoyanchev commented

Ping, Rob Winch.

[spring-projects-issues]

Rob Winch commented

+1 I think making it an implementation specific feature is a good idea. Additional features could be a Spring Session feature.

[spring-projects-issues]

Rossen Stoyanchev commented

Updated title to reflect actual change to be made. Previous title:
"WebSessionStore method to retrieve all WebSession to do the session management"

[spring-projects-issues]

Rossen Stoyanchev commented

I've added a getSessions() method on InMemoryWebSessionStore that returns an unmodifiable map.