Apply Nullability to the project

[artembilan]

More info in the Spring Framework 7.0 docs: https://docs.spring.io/spring-framework/reference/7.0/core/null-safety.html.

We can treat this issue an Epic and have sub-issues for specific tasks or dedicated module fixes.

This can be done in phase:

1. Migrate from deprecated org.springframework.lang.Nullable on properties methods to the org.jspecify.annotations.Nullable.
2. Migrate @org.springframework.lang.NonNullApi and @org.springframework.lang.NonNullFields pair to the @org.jspecify.annotations.NullMarked. However this would trigger the third phase.
3. Fix nullabilty errors in those @org.jspecify.annotations.NullMarked packages.
4. Add more and more @org.jspecify.annotations.NullMarked and fix respective nullability vulnerabilities in those package and modules.

Any other thoughts and possible ways to fix this huge task are welcome!

list (checked means someone has taken it )

• spring-integration-amqp
• spring-integration-camel
• spring-integration-cassandra
• spring-integration-core
• spring-integration-debezium
• spring-integration-event
• spring-integration-feed
• spring-integration-file
• spring-integration-ftp
• spring-integration-graphql
• spring-integration-groovy
• spring-integration-hazelcast
• spring-integration-http
• spring-integration-ip
• spring-integration-jdbc
• spring-integration-jms
• spring-integration-jmx
• spring-integration-jpa
• spring-integration-kafka
• spring-integration-mail
• spring-integration-mongodb
• spring-integration-r2dbc
• spring-integration-mqtt
• spring-integration-redis
• spring-integration-rsocket
• spring-integration-scripting
• spring-integration-sftp
• spring-integration-smb
• spring-integration-stomp
• spring-integration-stream
• spring-integration-syslog
• spring-integration-test
• spring-integration-test-support
• spring-integration-webflux
• spring-integration-websocket
• spring-integration-ws
• spring-integration-xml
• spring-integration-xmpp
• spring-integration-zeromq
• spring-integration-zip
• spring-integration-zookeeper

[anayonkars]

I would like to work on phase 1 of this - i.e.

1. Migrate from deprecated org.springframework.lang.Nullable on properties methods to the org.jspecify.annotations.Nullable.

[artembilan]

Thank you for offer, @anayonkars !

Can we go then some baby steps?
Like open Pull Request for spring-integration-amqp module first.
And we will figure out how to proceed from there.

I mean there are plethora of the org.springframework.lang.Nullable in the project.
So, going in one shot might be exhausting to implement and review.

[anayonkars]

@artembilan makes sense.
Though majority of the changes are find & replace, but PR will be too huge and it's risky to push such a big change in one shot.
Will raise PR for spring-integration-amqp.

[anthologia]

@artembilan
I'd also like to contribute to phase 1 of this Nullability migration. Could you suggest which module I should start with?

@anayonkars
Would you be interested in collaborating? We could work on different modules in parallel !

[artembilan]

Sounds great, @anthologia !

How about you go inverse alphabet and @anayonkars forward? 😉
So, you start from spring-integration-zookeeper and @anayonkars continues from spring-integration-camel since he has already issued the fix for spring-integration-amqp.

Thanks

[anthologia]

Thanks, @artembilan !

I'll start with spring-integration-zeromq (spring-integration-zip and spring-integration-zookeeper look good already) and work backwards from there.

And would it be helpful if we create a checklist to track progress across all modules? It could help avoid duplicate work and track overall progress. What approach would work best for this ? 🤔

[anayonkars]

@anthologia sure! I agree with @artembilan approach.

[cppwfs]

I'll be working on spring-integration-core

[mjd507]

And would it be helpful if we create a checklist to track progress across all modules? It could help avoid duplicate work and track overall progress.

I create one, @artembilan @cppwfs @anthologia @anayonkars, let me know if you have any concern.