diff --git a/config/src/main/java/org/springframework/security/config/annotation/web/builders/FilterOrderRegistration.java b/config/src/main/java/org/springframework/security/config/annotation/web/builders/FilterOrderRegistration.java index cddb6ce5e4b..09d9766f111 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/web/builders/FilterOrderRegistration.java +++ b/config/src/main/java/org/springframework/security/config/annotation/web/builders/FilterOrderRegistration.java @@ -127,11 +127,7 @@ final class FilterOrderRegistration { * @param position the position to associate with the {@link Filter} */ void put(Class filter, int position) { - String className = filter.getName(); - if (this.filterToOrder.containsKey(className)) { - return; - } - this.filterToOrder.put(className, position); + this.filterToOrder.putIfAbsent(filter.getName(), position); } /** diff --git a/core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java b/core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java index 78cec888126..cfd066a912a 100644 --- a/core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java +++ b/core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java @@ -68,14 +68,14 @@ public Collection getAuthorities() { @Override public String getName() { - if (this.getPrincipal() instanceof UserDetails) { - return ((UserDetails) this.getPrincipal()).getUsername(); + if (this.getPrincipal() instanceof UserDetails userDetails) { + return userDetails.getUsername(); } - if (this.getPrincipal() instanceof AuthenticatedPrincipal) { - return ((AuthenticatedPrincipal) this.getPrincipal()).getName(); + if (this.getPrincipal() instanceof AuthenticatedPrincipal authenticatedPrincipal) { + return authenticatedPrincipal.getName(); } - if (this.getPrincipal() instanceof Principal) { - return ((Principal) this.getPrincipal()).getName(); + if (this.getPrincipal() instanceof Principal principal) { + return principal.getName(); } return (this.getPrincipal() == null) ? "" : this.getPrincipal().toString(); } @@ -119,10 +119,9 @@ private void eraseSecret(Object secret) { @Override public boolean equals(Object obj) { - if (!(obj instanceof AbstractAuthenticationToken)) { + if (!(obj instanceof AbstractAuthenticationToken test)) { return false; } - AbstractAuthenticationToken test = (AbstractAuthenticationToken) obj; if (!this.authorities.equals(test.authorities)) { return false; } diff --git a/core/src/main/java/org/springframework/security/authentication/AnonymousAuthenticationToken.java b/core/src/main/java/org/springframework/security/authentication/AnonymousAuthenticationToken.java index 2e92d105f74..2e2a47b7e44 100644 --- a/core/src/main/java/org/springframework/security/authentication/AnonymousAuthenticationToken.java +++ b/core/src/main/java/org/springframework/security/authentication/AnonymousAuthenticationToken.java @@ -74,8 +74,7 @@ public boolean equals(Object obj) { if (!super.equals(obj)) { return false; } - if (obj instanceof AnonymousAuthenticationToken) { - AnonymousAuthenticationToken test = (AnonymousAuthenticationToken) obj; + if (obj instanceof AnonymousAuthenticationToken test) { return (this.getKeyHash() == test.getKeyHash()); } return false; diff --git a/core/src/main/java/org/springframework/security/authentication/jaas/JaasGrantedAuthority.java b/core/src/main/java/org/springframework/security/authentication/jaas/JaasGrantedAuthority.java index d0d76b89d1f..8096947840e 100644 --- a/core/src/main/java/org/springframework/security/authentication/jaas/JaasGrantedAuthority.java +++ b/core/src/main/java/org/springframework/security/authentication/jaas/JaasGrantedAuthority.java @@ -58,9 +58,8 @@ public boolean equals(Object obj) { if (this == obj) { return true; } - if (obj instanceof JaasGrantedAuthority) { - JaasGrantedAuthority jga = (JaasGrantedAuthority) obj; - return this.role.equals(jga.role) && this.principal.equals(jga.principal); + if (obj instanceof JaasGrantedAuthority jga) { + return this.role.equals(jga.getAuthority()) && this.principal.equals(jga.getPrincipal()); } return false; } diff --git a/core/src/main/java/org/springframework/security/core/authority/SimpleGrantedAuthority.java b/core/src/main/java/org/springframework/security/core/authority/SimpleGrantedAuthority.java index 71719d48010..54b889e6177 100644 --- a/core/src/main/java/org/springframework/security/core/authority/SimpleGrantedAuthority.java +++ b/core/src/main/java/org/springframework/security/core/authority/SimpleGrantedAuthority.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2023 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -50,8 +50,8 @@ public boolean equals(Object obj) { if (this == obj) { return true; } - if (obj instanceof SimpleGrantedAuthority) { - return this.role.equals(((SimpleGrantedAuthority) obj).role); + if (obj instanceof SimpleGrantedAuthority sga) { + return this.role.equals(sga.getAuthority()); } return false; } diff --git a/core/src/main/java/org/springframework/security/core/userdetails/User.java b/core/src/main/java/org/springframework/security/core/userdetails/User.java index 141f65dde81..2c518fd7d8e 100644 --- a/core/src/main/java/org/springframework/security/core/userdetails/User.java +++ b/core/src/main/java/org/springframework/security/core/userdetails/User.java @@ -179,8 +179,8 @@ private static SortedSet sortAuthorities(Collection