From 62e53cebc20c751024edaa835f2e14efd45ea29b Mon Sep 17 00:00:00 2001
From: Daniel Garnier-Moiroux <git@garnier.wf>
Date: Thu, 5 Sep 2024 14:07:55 +0200
Subject: [PATCH] Hardcode ott-username input name in
 DefaultLoginPageGeneratingFilter

- GenerateOneTimeTokenFilter uses `"username"`, the default UI should use the same parameter name
---
 .../authentication/ui/DefaultLoginPageGeneratingFilter.java   | 4 ++--
 .../authentication/DefaultLoginPageGeneratingFilterTests.java | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java b/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java
index efdc73e9a6d..042fc41d262 100644
--- a/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java
+++ b/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java
@@ -242,8 +242,8 @@ private String generateLoginPageHtml(HttpServletRequest request, boolean loginEr
 			sb.append("        <h2>Request a One-Time Token</h2>\n");
 			sb.append(createError(loginError, errorMsg) + createLogoutSuccess(logoutSuccess) + "<p>\n");
 			sb.append("          <label for=\"ott-username\" class=\"screenreader\">Username</label>\n");
-			sb.append("          <input type=\"text\" id=\"ott-username\" name=\"" + this.usernameParameter
-					+ "\" placeholder=\"Username\" required>\n");
+			sb.append(
+					"          <input type=\"text\" id=\"ott-username\" name=\"username\" placeholder=\"Username\" required>\n");
 			sb.append("        </p>\n");
 			sb.append(renderHiddenInputs(request));
 			sb.append("          <button class=\"primary\" type=\"submit\" form=\"ott-form\">Send Token</button>\n");
diff --git a/web/src/test/java/org/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java b/web/src/test/java/org/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java
index c1fe329f055..95277098787 100644
--- a/web/src/test/java/org/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java
+++ b/web/src/test/java/org/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java
@@ -199,7 +199,7 @@ public void generateWhenOneTimeTokenLoginThenOttForm() throws Exception {
 				        <h2>Request a One-Time Token</h2>
 				<p>
 				          <label for="ott-username" class="screenreader">Username</label>
-				          <input type="text" id="ott-username" name="null" placeholder="Username" required>
+				          <input type="text" id="ott-username" name="username" placeholder="Username" required>
 				        </p>
 				          <button class="primary" type="submit" form="ott-form">Send Token</button>
 				      </form>