Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataTypeCase & functionCase #689

Merged
merged 39 commits into from
Dec 7, 2023
Merged

Add dataTypeCase & functionCase #689

merged 39 commits into from
Dec 7, 2023

Conversation

nene
Copy link
Collaborator

@nene nene commented Dec 6, 2023

Continuation of PR #673

karlhorky and others added 25 commits November 29, 2023 18:19
@karlhorky
Identify PostgreSQL data types, add docs
bdf3be9
@karlhorky
Add docs for functionCase, rename to dataTypeCase
c6fb0b6
@karlhorky
Add caveat about dataTypeCase language support
2ba9d0a
@karlhorky
Move more data types to separate constant
10b4451
@karlhorky
Add TokenType.RESERVED_DATA_TYPE and dataTypeCase
a555575
@karlhorky
Merge branch 'separate-data-types' of github.com:karlhorky/sql-format…
129ba96 
…ter into add-datatypeformat-option
@karlhorky
Add functionCase option, make keywordCase default
4ae6c48
@karlhorky
Improve docs
f8df2f6
@karlhorky
Merge branch 'separate-data-types' of github.com:karlhorky/sql-format…
d57af57 
…ter into add-datatypeformat-option
@karlhorky
Switch to reservedDataTypes
9d4c929
@karlhorky
Revert to independent defaults
4f46845
@karlhorky
Merge branch 'sql-formatter-org:master' into add-datatypeformat-option
bf17e85
@karlhorky
Address ESLint no-nested-ternary rule error
9815a46
@karlhorky
Improve grammar and wording
fb60928
@karlhorky
Add tests for casing ARRAY data types
66d596e
@karlhorky
Add tests for dataTypeCase and functionCase
8d81244
@karlhorky
Improve docs
a4e4070
@karlhorky
Add NUMERIC
4ee4965
@nene
Revert funcNameToKeyword() to its previous form
96d3ef7
@nene
Remove data types from function name lists
23848a1
@nene
Move DB2 datatypes from functions to dataTypes array
8db91fa
@nene
Move DB2i datatypes from functions to dataTypes array
cf7a656
@nene
Move Spark datatypes from functions to dataTypes array
ea7f390
@nene
Parse parameterized data types to separate type of AST node
2ebd732
@nene
Remove support for ANY operator in SQLite
fdb8f32 
Other dialects might also not support it, haven't checked.
But SQLite is the only one with data type named "ANY".
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 6, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@nene nene mentioned this pull request Dec 6, 2023
Merged
@nene
Copy link
Collaborator Author

nene commented Dec 7, 2023

I'm still not sure how to best handle the ARRAY keyword/type.

In many dialects array literals are written as ARRAY[1, 2, 3] - here ARRAY is not a type, it's part of the literal syntax.

In BigQuery one can write just [1, 2, 3], but also ARRAY[1, 2, 3] and ARRAY<INT64>[1, 2, 3] - here ARRAY is a type.

At the moment in this PR the ARRAY[] is formatted as keyword, but ARRAY<INT64>[] as data type. Which isn't ideal.

Will need to do more research into how the ARRAY keyword is used in other dialects.

@nene nene merged commit 7e3db7f into master Dec 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nene @karlhorky