Fix review comments

sqlalchemy · Nov 1, 2024 · 32328f1 · 32328f1
1 parent e70fdc8
commit 32328f1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/alembic/ddl/impl.py b/alembic/ddl/impl.py
@@ -140,14 +140,19 @@ def static_output(self, text: str) -> None:
         self.output_buffer.flush()
 
     def version_table_impl(
-        self, *, version_table, version_table_schema, version_table_pk, **kw
+        self,
+        *,
+        version_table: str,
+        version_table_schema: Optional[str],
+        version_table_pk: bool,
+        **kw,
     ) -> Table:
         """create the Table object for the version_table.
 
         Provided as part of impl so that third party dialects can override
         this.
 
-        .. versionadded:: 1.13.4
+        .. versionadded:: 1.14
 
         """
         vt = Table(

diff --git a/tests/test_version_table.py b/tests/test_version_table.py
@@ -1,3 +1,5 @@
+from typing import Optional
+
 from sqlalchemy import Column
 from sqlalchemy import inspect
 from sqlalchemy import Integer
@@ -385,9 +387,9 @@ class MyDialectImpl(impl.DefaultImpl):
         def version_table_impl(
             self,
             *,
-            version_table,
-            version_table_schema,
-            version_table_pk,
+            version_table: str,
+            version_table_schema: Optional[str],
+            version_table_pk: bool,
             **kw,
         ):
             vt = Table(