Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up if_(not_)?exists to SQLAlchemy 1.4+ #1358

Closed
wants to merge 1 commit into from

Conversation

zrotceh
Copy link
Contributor

@zrotceh zrotceh commented Nov 16, 2023

Fixes #1323

Description

As the title describes, open up if_(not_)?exists support (both implementations and tests) to SQLAlchemy 1.4+

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

@zzzeek
Copy link
Member

zzzeek commented Nov 16, 2023

@CaselIT looks like 1.4.0b2 had the "if (not) exists" constructs, why were these gated on SQLAlchemy 2?

@CaselIT
Copy link
Member

CaselIT commented Nov 16, 2023

not sure, if they are in the 1.4 beta then it's probably just an error

@CaselIT
Copy link
Member

CaselIT commented Nov 16, 2023

ah the reason is the they were added to alembic following this issue for v2 sqlalchemy/sqlalchemy#7354, but some of the exists were already present

@CaselIT CaselIT requested a review from sqla-tester November 16, 2023 14:23
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision c678a31 of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change c678a31: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4974

@sqla-tester
Copy link
Collaborator

mike bayer (zzzeek) wrote:

can we get a changelog for this? thanks

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4974

@CaselIT
Copy link
Member

CaselIT commented Nov 16, 2023

will add

@CaselIT
Copy link
Member

CaselIT commented Nov 16, 2023

updated on gerrit

@sqla-tester
Copy link
Collaborator

mike bayer (zzzeek) wrote:

perfect, thanks all!

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4974

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4974 has been merged. Congratulations! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index creation with if_not_exists not supported for SQLAlchemy 1.4.49
4 participants