-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open up if_(not_)?exists
to SQLAlchemy 1.4+
#1358
Conversation
@CaselIT looks like 1.4.0b2 had the "if (not) exists" constructs, why were these gated on SQLAlchemy 2? |
not sure, if they are in the 1.4 beta then it's probably just an error |
ah the reason is the they were added to alembic following this issue for v2 sqlalchemy/sqlalchemy#7354, but some of the exists were already present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision c678a31 of this pull request into gerrit so we can run tests and reviews and stuff
New Gerrit review created for change c678a31: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4974 |
mike bayer (zzzeek) wrote: can we get a changelog for this? thanks View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4974 |
will add |
updated on gerrit |
mike bayer (zzzeek) wrote: perfect, thanks all! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4974 |
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4974 has been merged. Congratulations! :) |
Fixes #1323
Description
As the title describes, open up
if_(not_)?exists
support (both implementations and tests) to SQLAlchemy 1.4+Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit message