Use logging.WARNING instead of logging.WARN #1548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WARN constant is an undocumented alias for WARNING. Whilst it’s not deprecated, it’s not mentioned at all in the documentation.
|
ok! thanks for the PR |
sqla-tester
reviewed
Oct 5, 2024
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 249b9a2 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 249b9a2: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5518 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5518 has been merged. Congratulations! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WARNconstant is an undocumented alias forWARNING. Whilst it’s not deprecated, it’s not mentioned at all in the documentation. This references one offlake8-loggingplugins rule.Description
Changed all uses of
logging.WARNtologging.WARNING.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!