Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete typing for Engine.dispose's close parameter #243

Open
satyanash opened this issue Dec 12, 2022 · 1 comment
Open

Incomplete typing for Engine.dispose's close parameter #243

satyanash opened this issue Dec 12, 2022 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@satyanash
Copy link

Describe the bug
SQLAlchemy release 1.4.33 added a new optional close: bool = True parameter to Engine#dispose().
This is not declared in the type definition, at

def dispose(self) -> None: ...

Expected behavior
The current type definition should declare the close parameter.

To Reproduce
Call Engine.dispose(close) and then run mypy on it with sqlalchemy2-stubs.

engine.dispose(close=False)

Error

error: Too many arguments for "dispose" of "Engine"

Versions.

  • OS: Darwin Kernel Version 21.6.0
  • Python: 3.7.10
  • SQLAlchemy: 1.4.39
  • mypy: 0.931
  • SQLAlchemy2-stubs: 0.0.2a29
@satyanash satyanash added the requires triage New issue that requires categorization label Dec 12, 2022
@CaselIT CaselIT added bug Something isn't working help wanted Extra attention is needed and removed requires triage New issue that requires categorization labels Dec 12, 2022
@CaselIT
Copy link
Member

CaselIT commented Dec 12, 2022

Hi,

thanks for reporting. PRs welcomes to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants