Add __get__ to the column and relationship to improve usage #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the plugin is not supported, for example when using other type checkers.
zzzeek
reviewed
Sep 1, 2021
| @@ -0,0 +1,42 @@ | |||
| from typing import List | |||
There was a problem hiding this comment.
this gets tested with the plugin installed, so isnt really tested, right?
There was a problem hiding this comment.
yes, but the objective it to ensure that with the plugin nothing unsurprising happens.
I've looked at it in vscode and the types are inferred correctly
|
There is also column_property(), deferred(), query_property(), etc |
|
closing since for v2 we went on another direction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the plugin is not supported, for example when using other type checkers.
Description
This was taken from the dropbox stubs.
Fixes #170
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!