Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HttpOverHttp2Test flakes and bad cache behaviour #8230

Open
yschimke opened this issue Jan 30, 2024 · 1 comment · May be fixed by #8257
Open

Fix HttpOverHttp2Test flakes and bad cache behaviour #8230

yschimke opened this issue Jan 30, 2024 · 1 comment · May be fixed by #8257
Labels
bug Bug in existing code

Comments

@yschimke
Copy link
Collaborator

#8207 (comment)
@yschimke yschimke added the bug Bug in existing code label Jan 30, 2024
@yschimke yschimke mentioned this issue Jan 30, 2024
Merged
@yschimke
Copy link
Collaborator Author

Looking into this, I can reproduce the same sort of issues by adding concurrency.

    systemProperty("junit.jupiter.extensions.autodetection.enabled", "true")
    systemProperty("junit.jupiter.execution.parallel.enabled", "true")
    systemProperty("junit.jupiter.execution.parallel.mode.default", "concurrent")
    systemProperty("junit.jupiter.execution.parallel.config.strategy", "fixed")
    systemProperty("junit.jupiter.execution.parallel.config.fixed.parallelism", "4")

We could bump the timeouts, or possibly make the I/O in tests more predictable. I might put up a PR to highlight the problem.

@yschimke yschimke mentioned this issue Feb 10, 2024
Closed
@yschimke yschimke linked a pull request Feb 17, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug in existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Concurrent tests and avoid testing HTTP/2 Frames with Log Handler. yschimke/okhttp
1 participant
@yschimke