Upload progress recipe #8493
Open
Upload progress recipe #8493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @swankjesse @LouisCAD in case you have thoughts, otherwise I'll review next week |
|
@yschimke If you officially provide the recipe, it will be very helpful to new users |
swankjesse
reviewed
Nov 19, 2024
|
|
||
| @Override | ||
| public void writeTo(BufferedSink sink) throws IOException { | ||
| BufferedSink bufferSink = Okio.buffer(sink(sink)); |
There was a problem hiding this comment.
supernit: bufferedSink, not bufferSink
swankjesse
reviewed
Nov 19, 2024
| public void writeTo(BufferedSink sink) throws IOException { | ||
| BufferedSink bufferSink = Okio.buffer(sink(sink)); | ||
| requestBody.writeTo(bufferSink); | ||
| bufferSink.close(); |
There was a problem hiding this comment.
Remove this, the implementation of writeTo() shouldn’t close sink
swankjesse
reviewed
Nov 19, 2024
| private static class ProgressRequestBody extends RequestBody { | ||
|
|
||
| private final ProgressListener progressListener; | ||
| private final RequestBody requestBody; |
swankjesse
reviewed
Nov 19, 2024
| @Override | ||
| public void close() throws IOException { | ||
| super.close(); | ||
| progressListener.update(totalBytesWritten, contentLength(),true); |
There was a problem hiding this comment.
supernit: formatting. Space after ,
There was a problem hiding this comment.
MIGHT want to make this only call progressListener.update() once even if close() is called multiple times. You’re allowed to call close() multiple times but listeners shouldn’t be called more than once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear. @swankjesse
I improved the
upload progress recipediscussed in #1471 #1528It was rewritten based on the discussed requirements.
After discussion, I would like to write a Kotlin recipe
I'm awaiting your comments.
Thank you for your time