Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist: resolve group names #46

Open
sabaini opened this issue Jan 8, 2019 · 3 comments
Open

Wishlist: resolve group names #46

sabaini opened this issue Jan 8, 2019 · 3 comments

Comments

@sabaini
Copy link

sabaini commented Jan 8, 2019

For maintainability I'd love to be able to specify group names in addition to GIDs for gids_exempted.

My rust-foo is superficial at best but I'm thinking this should be doable by extending is_sudoing_from_exempted_gid() , what do you think?

@stouset
Copy link
Collaborator

stouset commented Jan 8, 2019

I would name this groups_exempted, since gids_exempted is a Vec<gid_t>. In the options parser, you could just do groupname => gid lookups and add them to gids_exempted.

If a groupname is not found, it should not error out.

@stouset
Copy link
Collaborator

stouset commented Feb 19, 2019

Is this still something you guys are interested in? I have a PR open, but I'd like feedback from you on use before I merge it.

@sabaini
Copy link
Author

sabaini commented Jan 16, 2020

Sorry for completely missing these updates! We're working around this now by resolving group -> gid at deployment time, but from a maintainability perspective this would still be good to have. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants