Add "Drafts" to Input #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperstorm
reviewed
Mar 12, 2024
|
This looks and feels good, similar to how Discord, Slack and other applications behave. |
|
Oops, sorry about that. CHANGELOG entry added. Happy to provide the single-pane-user perspective. |
casperstorm
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
I'll approve, and wait to see if @tarkah has any additional comments.
tarkah
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Awesome as always @andymandias! I've done a little cleanup, mainly removing the unneeded state on input_view::State since we can just update / reference the draft value from our stored history manager -> input widget.
… when switching between channels/queries/servers.
We can use the stored draft data in history::Manager as the text used by our input view, so we don't need to also store / update / refrence in the input view state. This eliminates de-sync risk and cuts out some unnecessary code. Also rearranged / renamed things a little.
casperstorm
force-pushed
the
input-draft
branch
from
8fabf66 to
588a38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to automatically store the contents of the input view, such that non-sent messages will persist when switching between channels/queries/servers. I.e. if I type out a part of a message for a channel, switch to another channel to reference other messages, then when I switch back to the original channel the part of the message that I typed will be restored. Previously, when switching channels the input is cleared and anything that has been typed is lost.