From d6025fa59c879170b4087b52d256e6d7ce0880b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Bundyra?= Date: Tue, 26 Nov 2019 20:06:14 +0000 Subject: [PATCH] Adds support for array closures in Generic.CodeAnalysis.UnusedFunctionParameter Related to #2523 --- .../Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php | 1 + .../Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.inc | 2 ++ .../Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.php | 1 + 3 files changed, 4 insertions(+) diff --git a/src/Standards/Generic/Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php b/src/Standards/Generic/Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php index e839f9bcf6..427f509cae 100644 --- a/src/Standards/Generic/Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php +++ b/src/Standards/Generic/Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php @@ -34,6 +34,7 @@ public function register() return [ T_FUNCTION, T_CLOSURE, + T_FN, ]; }//end register() diff --git a/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.inc b/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.inc index 3073e6fcdb..9997e787c5 100644 --- a/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.inc +++ b/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.inc @@ -121,3 +121,5 @@ function something($a) { function myCallback($a, $b, $c, $d) { return $a * $c; } + +fn ($a, $b, $c) => $b; diff --git a/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.php b/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.php index 583e049864..063c72073e 100644 --- a/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.php +++ b/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.php @@ -49,6 +49,7 @@ public function getWarningList() 106 => 1, 117 => 1, 121 => 2, + 125 => 2, ]; }//end getWarningList()