[Backport] Issue in adding the wishlist of "zero price" product #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig fixture. Set the schedule for every minute so that the job is scheduled regardless of the time when you run the test.
…ntal crawling magento#17163 - Merge Pull Request magento#17163 from cmtickle/magento2:noindex-nofollow-admin - Merged commits: 1. f9839bb 2. b1af6ad 3. 91e192b
# Conflicts: # app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCategoryProductAttributeActionGroup.xml # app/code/Magento/Catalog/Test/Mftf/ActionGroup/ProductsOnAdminActionGroup.xml # app/code/Magento/Catalog/Test/Mftf/Section/AdminProductAttributeEditSection.xml # app/code/Magento/Catalog/Test/Mftf/Section/AdminProductGridFilterSection.xml
…ons are selected for configurable product magento#8168
…nto MAGETWO-93345
… product in admin
# Conflicts: # app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCategoryProductAttributeActionGroup.xml # app/code/Magento/Catalog/Test/Mftf/ActionGroup/ProductsOnAdminActionGroup.xml # app/code/Magento/Catalog/Test/Mftf/Section/AdminProductAttributeEditSection.xml # app/code/Magento/Catalog/Test/Mftf/Section/AdminProductGridFilterSection.xml
…ial invoices - Added application isolation level for tests
…plied to an order - Fixed incorrect shipping discount calculation when taxes are included in shipping price - Fixed incorrect BaseShippingDiscountTaxCompensationAmount calculation for PayPal - Total amounts sent to PayPal were rounded for 2 signs
…ons are selected for configurable product magento#8168
…results in the element's state being changed
…r switching from production mode to developer magento#15335
…tribute Repository magento#15691
[chaika] MAGETWO-93054: Admin logs don't detail quantity changes
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#17405: [Braintree] Added unit test for instant purchase PayPal token formatter (by @rogyar) - magento#15335: Fixed issue magento#13480 - Unable to activate logs after switching from production mode to developer (by @jayankaghosh) - magento#15606: Fix magento#10687 - Product image roles disappearing (by @Scarraban) - magento#15720: Convert to string $option->getValue, in order to be compared with oth� (by @zamboten) - magento#16597: Save configurable product options after validation error (by @swnsma) - magento#16955: fix: remove disabled attribute on region list (by @DanielRuf) - magento#14537: magento#12250: View.xml is inheriting image sizes from paren� (by @quisse) - magento#17078: MAGETWO-84608: Cannot perform setup:install if Redis needs a password� (by @guillaumegiordana) - magento#15691: Fix magento#4803: Incorrect return value from Product Attribute Repository (by @cream-julian) - magento#16724: 16544: fixed behaviour when some of JS validation rules making fields� (by @VitaliyBoyko) Fixed GitHub Issues: - magento#13480: Unable to activate logs after switching from production mode to developer (reported by @VincentMarmiesse) has been fixed in magento#15335 by @jayankaghosh in 2.2-develop branch Related commits: 1. 540917e 2. c6aabf8 - magento#10687: Product image roles randomly disappear (reported by @boxyman) has been fixed in magento#15606 by @Scarraban in 2.2-develop branch Related commits: 1. a99e97e - magento#15028: Configurable product addtocart with restAPI not working as expected (reported by @yspeedwicked) has been fixed in magento#15720 by @zamboten in 2.2-develop branch Related commits: 1. 03298b3 - magento#7372: Product images gets removed from "Images And Videos" after validation alert. (reported by @candia) has been fixed in magento#16597 by @swnsma in 2.2-develop branch Related commits: 1. d866b18 2. bc00d8e - magento#13177: Can't save attributes on a configurable product (reported by @bambamboole) has been fixed in magento#16597 by @swnsma in 2.2-develop branch Related commits: 1. d866b18 2. bc00d8e - magento#12250: View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent) (reported by @quisse) has been fixed in magento#14537 by @quisse in 2.2-develop branch Related commits: 1. ca47981 2. 951d5e8 3. 96c28a6 - magento#4803: Incorrect return value from Product Attribute Repository (reported by @samtay) has been fixed in magento#15691 by @cream-julian in 2.2-develop branch Related commits: 1. 4c1989e 2. 215be5a 3. 2639d0e 4. 43dd85e - magento#16544: Some of JS validation rules making fields required (reported by @VitaliyBoyko) has been fixed in magento#16724 by @VitaliyBoyko in 2.2-develop branch Related commits: 1. e189fc9 2. 2ed9af3 3. e71836b 4. c6a8fec
magento-team
pushed a commit
that referenced
this pull request
Sep 25, 2018
[Backport] Use route ID when creating secret keys in backend menus instead of route name
sreichel
pushed a commit
that referenced
this pull request
Oct 17, 2018
sreichel
pushed a commit
that referenced
this pull request
Oct 29, 2018
Fixed issues-18534: 2 wysiwyg on catalog category edit page
sreichel
pushed a commit
that referenced
this pull request
Nov 8, 2018
Remove unnecesary "header" block redeclaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#16537
Description
Fixed add to wishtlist item which price is zero.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist