Camera connect retry, address issue #21 #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, looking for feedback....DO NOT MERGE
This PR addresses issue #21 and includes PR #22.
The node now waits for the camera to be connected before starting up. I made changes to the
CameraPtr AvtVimbaCamera::openCamera(std::string id_str)method insrc/avt_vimba_camera.cpp.I'm looking for feedback on these changes. I am not a fan of using
ros::ok(), since it does introduce ROS at a layer where is probably doesn't belong. However, without this, the node does not respond properly to aCtrl-C. I also do not like how thevimba_systemmust be restarted. I'm not familar with the API, so this was basically a result of guessing and testing. However, without the restart, the system never recognizes a camera, even once it's plugged in.